* [rfa] missing include in c-lang.c
@ 2002-09-20 10:12 David Carlton
2002-09-20 10:19 ` Andrew Cagney
0 siblings, 1 reply; 5+ messages in thread
From: David Carlton @ 2002-09-20 10:12 UTC (permalink / raw)
To: gdb-patches
c-lang.c calls strcmp(), but it doesn't seem to be declared anywhere,
so I think it should #include "gdb_string.h".
I suppose that I really should just commit this as obvious, but I'm
doing an RFA anyways.
David Carlton
carlton@math.stanford.edu
2002-09-20 David Carlton <carlton@math.stanford.edu>
* c-lang.c: #include "gdb_string.h"
Index: c-lang.c
===================================================================
RCS file: /cvs/src/src/gdb/c-lang.c,v
retrieving revision 1.15
diff -u -p -r1.15 c-lang.c
--- c-lang.c 20 Sep 2002 00:24:01 -0000 1.15
+++ c-lang.c 20 Sep 2002 17:09:33 -0000
@@ -30,6 +30,7 @@
#include "macroscope.h"
#include "gdb_assert.h"
#include "charset.h"
+#include "gdb_string.h"
extern void _initialize_c_language (void);
static void c_emit_char (int c, struct ui_file * stream, int quoter);
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [rfa] missing include in c-lang.c
2002-09-20 10:12 [rfa] missing include in c-lang.c David Carlton
@ 2002-09-20 10:19 ` Andrew Cagney
2002-09-20 10:41 ` David Carlton
2002-09-20 10:55 ` Elena Zannoni
0 siblings, 2 replies; 5+ messages in thread
From: Andrew Cagney @ 2002-09-20 10:19 UTC (permalink / raw)
To: David Carlton; +Cc: gdb-patches
> c-lang.c calls strcmp(), but it doesn't seem to be declared anywhere,
> so I think it should #include "gdb_string.h".
>
> I suppose that I really should just commit this as obvious, but I'm
> doing an RFA anyways.
Yes, obvious.
Andrew
> David Carlton
> carlton@math.stanford.edu
>
> 2002-09-20 David Carlton <carlton@math.stanford.edu>
>
> * c-lang.c: #include "gdb_string.h"
>
> Index: c-lang.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/c-lang.c,v
> retrieving revision 1.15
> diff -u -p -r1.15 c-lang.c
> --- c-lang.c 20 Sep 2002 00:24:01 -0000 1.15
> +++ c-lang.c 20 Sep 2002 17:09:33 -0000
> @@ -30,6 +30,7 @@
> #include "macroscope.h"
> #include "gdb_assert.h"
> #include "charset.h"
> +#include "gdb_string.h"
>
> extern void _initialize_c_language (void);
> static void c_emit_char (int c, struct ui_file * stream, int quoter);
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [rfa] missing include in c-lang.c
2002-09-20 10:19 ` Andrew Cagney
@ 2002-09-20 10:41 ` David Carlton
2002-09-20 10:55 ` Elena Zannoni
1 sibling, 0 replies; 5+ messages in thread
From: David Carlton @ 2002-09-20 10:41 UTC (permalink / raw)
To: Andrew Cagney; +Cc: gdb-patches
On Fri, 20 Sep 2002 13:18:58 -0400, Andrew Cagney <ac131313@ges.redhat.com> said:
>> c-lang.c calls strcmp(), but it doesn't seem to be declared anywhere,
>> so I think it should #include "gdb_string.h".
>> I suppose that I really should just commit this as obvious, but I'm
>> doing an RFA anyways.
> Yes, obvious.
Committed.
David Carlton
carlton@math.stanford.edu
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [rfa] missing include in c-lang.c
2002-09-20 10:19 ` Andrew Cagney
2002-09-20 10:41 ` David Carlton
@ 2002-09-20 10:55 ` Elena Zannoni
2002-09-20 11:16 ` David Carlton
1 sibling, 1 reply; 5+ messages in thread
From: Elena Zannoni @ 2002-09-20 10:55 UTC (permalink / raw)
To: Andrew Cagney; +Cc: David Carlton, gdb-patches
Andrew Cagney writes:
> > c-lang.c calls strcmp(), but it doesn't seem to be declared anywhere,
> > so I think it should #include "gdb_string.h".
> >
> > I suppose that I really should just commit this as obvious, but I'm
> > doing an RFA anyways.
>
> Yes, obvious.
>
> Andrew
>
Makefile.in should be updated too.
Elena
> > David Carlton
> > carlton@math.stanford.edu
> >
> > 2002-09-20 David Carlton <carlton@math.stanford.edu>
> >
> > * c-lang.c: #include "gdb_string.h"
> >
> > Index: c-lang.c
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/c-lang.c,v
> > retrieving revision 1.15
> > diff -u -p -r1.15 c-lang.c
> > --- c-lang.c 20 Sep 2002 00:24:01 -0000 1.15
> > +++ c-lang.c 20 Sep 2002 17:09:33 -0000
> > @@ -30,6 +30,7 @@
> > #include "macroscope.h"
> > #include "gdb_assert.h"
> > #include "charset.h"
> > +#include "gdb_string.h"
> >
> > extern void _initialize_c_language (void);
> > static void c_emit_char (int c, struct ui_file * stream, int quoter);
> >
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [rfa] missing include in c-lang.c
2002-09-20 10:55 ` Elena Zannoni
@ 2002-09-20 11:16 ` David Carlton
0 siblings, 0 replies; 5+ messages in thread
From: David Carlton @ 2002-09-20 11:16 UTC (permalink / raw)
To: Elena Zannoni; +Cc: Andrew Cagney, gdb-patches
On Fri, 20 Sep 2002 13:53:41 -0400, Elena Zannoni <ezannoni@redhat.com> said:
> Makefile.in should be updated too.
Whoops! Thanks for reminding me.
David Carlton
carlton@math.stanford.edu
2002-09-20 David Carlton <carlton@math.stanford.edu>
* Makefile.in (c-lang.o): Correct dependencies.
(utils.o): Gather dependencies.
(charset.o): Move.
Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.262
diff -u -p -r1.262 Makefile.in
--- Makefile.in 20 Sep 2002 14:58:59 -0000 1.262
+++ Makefile.in 20 Sep 2002 18:13:53 -0000
@@ -1560,7 +1560,7 @@ builtin-regs.o: builtin-regs.c $(defs_h)
$(gdb_string_h) $(gdb_assert_h)
c-lang.o: c-lang.c $(defs_h) $(symtab_h) $(gdbtypes_h) $(expression_h) \
$(parser_defs_h) $(language_h) $(c_lang_h) $(valprint_h) \
- $(macroscope_h) $(gdb_assert_h)
+ $(macroscope_h) $(gdb_assert_h) $(charset_h) $(gdb_string_h)
c-typeprint.o: c-typeprint.c $(defs_h) $(gdb_obstack_h) $(bfd_h) $(symtab_h) \
$(gdbtypes_h) $(expression_h) $(value_h) $(gdbcore_h) $(target_h) \
$(language_h) $(demangle_h) $(c_lang_h) $(typeprint_h) $(cp_abi_h) \
@@ -1572,6 +1572,7 @@ c-valprint.o: c-valprint.c $(defs_h) $(g
# OBSOLETE ch-lang.o: ch-lang.c
# OBSOLETE ch-typeprint.o: ch-typeprint.c
# OBSOLETE ch-valprint.o: ch-valprint.c
+charset.o: charset.c $(defs_h) $(charset_h) $(gdbcmd_h) gdb_assert.h
cli-out.o: cli-out.c $(defs_h) $(ui_out_h) $(cli_out_h) $(gdb_string_h) \
$(gdb_assert_h)
coff-solib.o: coff-solib.c $(defs_h) $(frame_h) $(bfd_h) $(gdbcore_h) \
@@ -2242,7 +2243,7 @@ ui-out.o: ui-out.c $(defs_h) $(gdb_strin
utils.o: utils.c $(config_h) $(defs_h) $(gdb_assert_h) $(gdb_string_h) \
$(event_top_h) $(gdbcmd_h) $(serial_h) $(bfd_h) $(target_h) \
$(demangle_h) $(expression_h) $(language_h) $(annotate_h) \
- $(filenames_h) $(inferior_h) $(mmalloc_h)
+ $(filenames_h) $(inferior_h) $(mmalloc_h) $(charset_h)
uw-thread.o: uw-thread.c $(defs_h) $(gdbthread_h) $(target_h) $(inferior_h) \
$(regcache_h) $(gregset_h)
v850-tdep.o: v850-tdep.c $(defs_h) $(frame_h) $(inferior_h) $(target_h) \
@@ -2588,8 +2589,4 @@ xdr_rdb.o: vx-share/xdr_rdb.c $(defs_h)
vx-share/vxWorks.h vx-share/xdr_rdb.h
$(CC) -c $(INTERNAL_CFLAGS) $(srcdir)/vx-share/xdr_rdb.c
-charset.o: charset.c $(defs_h) $(charset_h) $(gdbcmd_h) gdb_assert.h
-
-c-lang.o: $(charset_h)
-utils.o: $(charset_h)
### end of the gdb Makefile.in.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2002-09-20 18:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-09-20 10:12 [rfa] missing include in c-lang.c David Carlton
2002-09-20 10:19 ` Andrew Cagney
2002-09-20 10:41 ` David Carlton
2002-09-20 10:55 ` Elena Zannoni
2002-09-20 11:16 ` David Carlton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox