From: Elena Zannoni <ezannoni@redhat.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sources.redhat.com, Elena Zannoni <ezannoni@redhat.com>
Subject: Re: [PATCH] rs6000-tdep.c: Undelete altivec_register_p()
Date: Mon, 26 Aug 2002 16:54:00 -0000 [thread overview]
Message-ID: <15722.48814.404070.175813@localhost.redhat.com> (raw)
In-Reply-To: <1020826232937.ZM581@localhost.localdomain>
Kevin Buettner writes:
> I've just committed the patch below. It fixes gdb/667. Thanks to Adam
> Fedor for reporting this problem.
>
> I considered moving altivec_register_p() into ppc-linux-nat.c, but it
> seems likely that this function will be useful in other files as other
> native ports are made altivec aware. Thus, it makes more sense to leave
> it in rs6000-tdep.c.
Ooopss, thanks. I have been a bit to enthusiastic about deleting code.
Elena
>
> * rs6000-tdep.c (altivec_register_p): Restore function inadvertently
> deleted in 2002-08-20 commit. This function is still used by
> ppc-linux-nat.c.
>
> Index: rs6000-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v
> retrieving revision 1.80
> diff -u -p -r1.80 rs6000-tdep.c
> --- rs6000-tdep.c 25 Aug 2002 15:18:41 -0000 1.80
> +++ rs6000-tdep.c 26 Aug 2002 23:16:25 -0000
> @@ -123,6 +123,17 @@ static void frame_get_saved_regs (struct
> struct rs6000_framedata * fdatap);
> static CORE_ADDR frame_initial_stack_address (struct frame_info *);
>
> +/* Is REGNO an AltiVec register? Return 1 if so, 0 otherwise. */
> +int
> +altivec_register_p (int regno)
> +{
> + struct gdbarch_tdep *tdep = gdbarch_tdep (current_gdbarch);
> + if (tdep->ppc_vr0_regnum < 0 || tdep->ppc_vrsave_regnum < 0)
> + return 0;
> + else
> + return (regno >= tdep->ppc_vr0_regnum && regno <= tdep->ppc_vrsave_regnum);
> +}
> +
> /* Read a LEN-byte address from debugged memory address MEMADDR. */
>
> static CORE_ADDR
prev parent reply other threads:[~2002-08-26 23:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-26 16:52 Kevin Buettner
2002-08-26 16:54 ` Elena Zannoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15722.48814.404070.175813@localhost.redhat.com \
--to=ezannoni@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox