From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27442 invoked by alias); 26 Aug 2002 23:52:01 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27412 invoked from network); 26 Aug 2002 23:52:01 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 26 Aug 2002 23:52:01 -0000 Received: by localhost.redhat.com (Postfix, from userid 469) id 9DF0210AAA; Mon, 26 Aug 2002 19:50:06 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15722.48814.404070.175813@localhost.redhat.com> Date: Mon, 26 Aug 2002 16:54:00 -0000 To: Kevin Buettner Cc: gdb-patches@sources.redhat.com, Elena Zannoni Subject: Re: [PATCH] rs6000-tdep.c: Undelete altivec_register_p() In-Reply-To: <1020826232937.ZM581@localhost.localdomain> References: <1020826232937.ZM581@localhost.localdomain> X-SW-Source: 2002-08/txt/msg00877.txt.bz2 Kevin Buettner writes: > I've just committed the patch below. It fixes gdb/667. Thanks to Adam > Fedor for reporting this problem. > > I considered moving altivec_register_p() into ppc-linux-nat.c, but it > seems likely that this function will be useful in other files as other > native ports are made altivec aware. Thus, it makes more sense to leave > it in rs6000-tdep.c. Ooopss, thanks. I have been a bit to enthusiastic about deleting code. Elena > > * rs6000-tdep.c (altivec_register_p): Restore function inadvertently > deleted in 2002-08-20 commit. This function is still used by > ppc-linux-nat.c. > > Index: rs6000-tdep.c > =================================================================== > RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v > retrieving revision 1.80 > diff -u -p -r1.80 rs6000-tdep.c > --- rs6000-tdep.c 25 Aug 2002 15:18:41 -0000 1.80 > +++ rs6000-tdep.c 26 Aug 2002 23:16:25 -0000 > @@ -123,6 +123,17 @@ static void frame_get_saved_regs (struct > struct rs6000_framedata * fdatap); > static CORE_ADDR frame_initial_stack_address (struct frame_info *); > > +/* Is REGNO an AltiVec register? Return 1 if so, 0 otherwise. */ > +int > +altivec_register_p (int regno) > +{ > + struct gdbarch_tdep *tdep = gdbarch_tdep (current_gdbarch); > + if (tdep->ppc_vr0_regnum < 0 || tdep->ppc_vrsave_regnum < 0) > + return 0; > + else > + return (regno >= tdep->ppc_vr0_regnum && regno <= tdep->ppc_vrsave_regnum); > +} > + > /* Read a LEN-byte address from debugged memory address MEMADDR. */ > > static CORE_ADDR