Re: [PATCH] gdb, configure: Add disable-formats option for configure

[Guinevere Larsen <guinevere@redhat.com>]

On 10/17/24 4:43 PM, Tom Tromey wrote:
>>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
> Andrew> While it is true that this change allows GDB to handle an objfile that
> Andrew> is can't otherwise understand, I wonder, how useful is it to even keep
> Andrew> the objfile around at all?
>
> IMO not very.  What contribution could it really make?
>
> Andrew> +struct scoped_objfile_remover
> Andrew> +{
>
> If it's at all possible it might be nice to clean up objfile creation
> and registration.  That is, it seems gross that creation registers the
> objfile, as opposed to there being two steps: create and populate it,
> and only then transfer ownership to the pspace.
>
> I understand in advance if that's not practical.
>
> Tom
>
We just chatted about this today, and I decided to give it a shot, 
because it also sounds better to me.

Apparently things just work after one run of the testsuite, but I'll do 
a bit more due diligence before sending that.

-- 
Cheers,
Guinevere Larsen
She/Her/Hers