From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cfTmGi9qEWd8RxEAWB0awg (envelope-from ) for ; Thu, 17 Oct 2024 15:49:03 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=RcUUkJfl; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 547C71E35F; Thu, 17 Oct 2024 15:49:03 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-7.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A5DE01E05C for ; Thu, 17 Oct 2024 15:49:02 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 55AC5385840A for ; Thu, 17 Oct 2024 19:49:02 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 772633858D20 for ; Thu, 17 Oct 2024 19:48:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 772633858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 772633858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1729194525; cv=none; b=dBW4mVUcJzV/ls8Cf67xhx22J2sNpjV3jIe4PVcMvi/FECHlxNC5FXmJW5axUoRnuEam8AMXC12uf1utaEia77YILnR1OkF5OdE7eNYXcGGFCe/B9lHC/jiiDTXemzy3IeE0YxAcwLt+sis+JFhvsaiDwfy2ieuyNf3Hhlbavsc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1729194525; c=relaxed/simple; bh=6zb9zphTiJmvnpi6Z4pDRtMYPJkff+yn8lQaoH25Zm0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=B25H/VM1/VbYtrld+1plTADaNX1eBI7hlbbgpJD42/7+3cBzACm77E/i/2Mubml3zdJHGVtLz9uqdV0x5eK7LAvHkXFQ76h7rWj38JB+KA+Jz/KSaAITuthioUBt/pLWovzW23aDgI5ZIhxqbMMG4Qr3BehOE+uKbMvV2N4oEuc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729194521; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YhEGuqzj4HbzgoIB0aZ4/WM35ihTTv31YGBS99/5KRI=; b=RcUUkJfl6YR6J7KAQKiQoFCWverxes4DMidi2DJHcwpkW5+bQTLMpaQeSfHcG1FzTfXzWw 3lqeoWFn8Sdeeyexta9FLIsDiMCzh1nfdsd9mpYl2RWKu0K4GkaeBatjZqrA3kKxkh1Omm b4LpemqyNgWtAmm2e+6Bw2zkQVuR6Gw= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-475-hztHPGUfOjWboKR6nMbJWw-1; Thu, 17 Oct 2024 15:48:40 -0400 X-MC-Unique: hztHPGUfOjWboKR6nMbJWw-1 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7b15499a04eso126308285a.1 for ; Thu, 17 Oct 2024 12:48:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729194519; x=1729799319; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YhEGuqzj4HbzgoIB0aZ4/WM35ihTTv31YGBS99/5KRI=; b=Bmv6KhVQEfytSJ4ibPYf+DW5LDfKDIihxi9S1WWWAH/8gyK9AI/od8kbpZkXNihpsb jR2qZkKPR917whKjajRny6kxyKUejFBnGmuSDlCaF/k1pSTDRA6AqSo5ritxn7SXpjpa bisSqdHlMx/Ruze1RvJIVaIG1E8e+ZIB+U5VxQ9GJJpePVC14uOvg4Z4ah+RH5U6J/d2 J7zgZWkRtM+hXcZSB4DOzlHlvyvcjZ0sMphqJSo3jy004S2YlmKhQRUqf9oV3jo3eoBD Rs0Ia7Xq1/7JcRCEQLbEcBU0nWDq/S8473crdbmItozTSf8qg4n3pixKeYn/xnbbUETk H4CA== X-Gm-Message-State: AOJu0YxlXYYIyUIUUiHwKFDdef4gGWObSh033C34dPvxyOkCH9ullwYn oHwhWrsb8g5wgWNJJKaNSNo+dHxdcGJ1yzvOfEEKfcBeNvMdXUKY9h5Um0BTtHp1Hr68x20wnbw Oi5C2K8mhOS8YBnDJwEIOPPAX1GUOc41e387alqFUKuXg7yYMdWtQdMtJo2WNYcz0YxE= X-Received: by 2002:a05:620a:2098:b0:7b1:5545:7104 with SMTP id af79cd13be357-7b15545732emr245007685a.2.1729194519348; Thu, 17 Oct 2024 12:48:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGBeQ1ogrwHTLkLXHVbjvJm/3fbxvzrPip1mijOXlkKnDeds4B7iAH0ZB+xiuczH8K7/GB3xQ== X-Received: by 2002:a05:620a:2697:b0:7b1:3c0e:3289 with SMTP id af79cd13be357-7b156bf27camr62614385a.22.1729194507924; Thu, 17 Oct 2024 12:48:27 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:92c5::1000? ([2804:14d:8084:92c5::1000]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b156fee62asm2854085a.99.2024.10.17.12.48.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Oct 2024 12:48:27 -0700 (PDT) Message-ID: <15696dbb-c95e-4b34-b523-21ce69481327@redhat.com> Date: Thu, 17 Oct 2024 16:48:25 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb, configure: Add disable-formats option for configure To: Tom Tromey , Andrew Burgess Cc: gdb-patches@sourceware.org References: <20240925175340.1850969-1-guinevere@redhat.com> <878qv3ylcf.fsf@redhat.com> <69c6f0f0-d8b5-4b69-8779-0bcbc3178324@redhat.com> <87h69c1fuh.fsf@redhat.com> <87frouecr4.fsf@tromey.com> From: Guinevere Larsen In-Reply-To: <87frouecr4.fsf@tromey.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 10/17/24 4:43 PM, Tom Tromey wrote: >>>>>> "Andrew" == Andrew Burgess writes: > Andrew> While it is true that this change allows GDB to handle an objfile that > Andrew> is can't otherwise understand, I wonder, how useful is it to even keep > Andrew> the objfile around at all? > > IMO not very. What contribution could it really make? > > Andrew> +struct scoped_objfile_remover > Andrew> +{ > > If it's at all possible it might be nice to clean up objfile creation > and registration. That is, it seems gross that creation registers the > objfile, as opposed to there being two steps: create and populate it, > and only then transfer ownership to the pspace. > > I understand in advance if that's not practical. > > Tom > We just chatted about this today, and I decided to give it a shot, because it also sounds better to me. Apparently things just work after one run of the testsuite, but I'll do a bit more due diligence before sending that. -- Cheers, Guinevere Larsen She/Her/Hers