From: Elena Zannoni <ezannoni@redhat.com>
To: Andrew Cagney <ac131313@ges.redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch/rfc/rfa:sh] gdbarch_register_read() -> gdbarch_cooked_register_read()
Date: Thu, 25 Jul 2002 12:15:00 -0000 [thread overview]
Message-ID: <15680.18245.941961.80077@localhost.redhat.com> (raw)
In-Reply-To: <15679.65247.570968.415011@localhost.redhat.com>
Elena Zannoni writes:
> Andrew Cagney writes:
> > Hello,
> >
> > The attached patch replaces the architecture vector interface:
> >
> > void gdbarch_register_read (struct gdbarch *gdbarch, int regnum, char
> > *buf);
> >
> > with the new interface:
> >
> > void gdbarch_cooked_register_read (struct gdbarch *gdbarch, struct
> > regcache *regcache, int regnum, void *buf)
> >
> > and then fixes the consequnces (all syntatic).
> >
> >
> > One NB. The parameter set is technically redundant. The assertion:
> >
> > gdbarch == regcache_gdbarch (regcache)
> >
> > always holds so the gdbarch parameter isn't strictly needed. I figured
> > that it is more convenient to include the gdbarch as a parameter and
> > save everyone the hassle of including the above line in their *-tdep code.
> >
> > The SH stuff should be reviewed. I think its on the right track since
> > sh-tdep.c no longer refers to current_regcache!!!
> >
So, wait a minute, is the sh the only port that overwrites the generic
register reads and writes to handle pseudo registers?
Elena
next prev parent reply other threads:[~2002-07-25 18:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-24 16:47 Andrew Cagney
2002-07-25 6:57 ` Elena Zannoni
2002-07-25 12:15 ` Elena Zannoni [this message]
2002-07-25 12:51 ` Andrew Cagney
2002-07-25 13:11 ` Elena Zannoni
2002-07-30 7:18 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15680.18245.941961.80077@localhost.redhat.com \
--to=ezannoni@redhat.com \
--cc=ac131313@ges.redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox