From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-17110-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 20760 invoked by alias); 25 Jul 2002 18:47:06 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 20752 invoked from network); 25 Jul 2002 18:47:05 -0000
Received: from unknown (HELO localhost.redhat.com) (66.30.197.194)
  by sources.redhat.com with SMTP; 25 Jul 2002 18:47:05 -0000
Received: by localhost.redhat.com (Postfix, from userid 469)
	id 88E80108C9; Thu, 25 Jul 2002 14:45:26 -0400 (EDT)
From: Elena Zannoni <ezannoni@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <15680.18245.941961.80077@localhost.redhat.com>
Date: Thu, 25 Jul 2002 12:15:00 -0000
To: Andrew Cagney <ac131313@ges.redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch/rfc/rfa:sh] gdbarch_register_read() -> gdbarch_cooked_register_read()
In-Reply-To: <15679.65247.570968.415011@localhost.redhat.com>
References: <3D3F34BF.3080902@ges.redhat.com>
	<15679.65247.570968.415011@localhost.redhat.com>
X-SW-Source: 2002-07/txt/msg00513.txt.bz2

Elena Zannoni writes:
 > Andrew Cagney writes:
 >  > Hello,
 >  > 
 >  > The attached patch replaces the architecture vector interface:
 >  > 
 >  >    void gdbarch_register_read (struct gdbarch *gdbarch, int regnum, char 
 >  > *buf);
 >  > 
 >  > with the new interface:
 >  > 
 >  >    void gdbarch_cooked_register_read (struct gdbarch *gdbarch, struct 
 >  > regcache *regcache, int regnum, void *buf)
 >  > 
 >  > and then fixes the consequnces (all syntatic).
 >  > 
 >  > 
 >  > One NB.  The parameter set is technically redundant.  The assertion:
 >  > 
 >  > 	gdbarch == regcache_gdbarch (regcache)
 >  > 
 >  > always holds so the gdbarch parameter isn't strictly needed.  I figured 
 >  > that it is more convenient to include the gdbarch as a parameter and 
 >  > save everyone the hassle of including the above line in their *-tdep code.
 >  > 
 >  > The SH stuff should be reviewed.  I think its on the right track since 
 >  > sh-tdep.c no longer refers to current_regcache!!!
 >  > 


So, wait a minute, is the sh the only port that overwrites the generic
register reads and writes to handle pseudo registers?


Elena