Re: [RFA] sim-h8300.h new file

[Elena Zannoni <ezannoni@redhat.com>]

Andrew Volkov writes:
 > Hi,
 > 
 > This patch prepared to fix ugly difference in sim and gdb
 > 
 > ok to commit?
 > 

The idea is good, however you should try to follow the same style that
sim-sh.h and sim-arm.h are using, in particular, look at the latest
patches and discussion for the sh file.

http://sources.redhat.com/ml/gdb-patches/2002-07/msg00393
This message addresses the same issues.

Elena


 > Andrey
 > 
 > Index: ./include/gdb/sim-h8300.h
 > ===================================================================
 > RCS file: ./include/gdb/sim-h8300.h
 > diff -N ./include/gdb/sim-h8300.h
 > --- /dev/null	1 Jan 1970 00:00:00 -0000
 > +++ ./include/gdb/sim-h8300.h	22 Jul 2002 13:30:08 -0000
 > @@ -0,0 +1,77 @@
 > +/* This file defines the interface between the sh simulator and gdb.
 > +   Copyright (C) 2002 Free Software Foundation, Inc.
 > +
 > +This file is part of GDB.
 > +
 > +This program is free software; you can redistribute it and/or modify
 > +it under the terms of the GNU General Public License as published by
 > +the Free Software Foundation; either version 2 of the License, or
 > +(at your option) any later version.
 > +
 > +This program is distributed in the hope that it will be useful,
 > +but WITHOUT ANY WARRANTY; without even the implied warranty of
 > +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 > +GNU General Public License for more details.
 > +
 > +You should have received a copy of the GNU General Public License
 > +along with this program; if not, write to the Free Software
 > +Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
 > */
 > +
 >  
 > +#if !defined (SIM_H8300_H)
 > +#define SIM_H8300_H
 > +  
 > +#ifdef __cplusplus
 > +extern "C" {// }
 > +#endif
 > +  
 > +/* The simulator makes use of the following register information. */ 
 > +  
 > +/* Registers common to all the H8 variants. */
 > +  enum
 > +  {
 > +    H8300_R0_REGNUM = 0,
 > +    H8300_R1_REGNUM,
 > +    H8300_R2_REGNUM,
 > +    H8300_R3_REGNUM,
 > +    H8300_R4_REGNUM,
 > +    H8300_R5_REGNUM,
 > +    H8300_R6_REGNUM,
 > +    H8300_R7_REGNUM,
 > +
 > +    H8300_PC_REGNUM,		/* Contains program counter */
 > +    H8300_CCR_REGNUM,		/* Contains processor status */
 > +    H8300_NUM_COMMON_REGS,
 > +
 > +    ARG_FIRST_REGNUM = H8300_R0_REGNUM,	/* first reg in which an arg
 > 
 > +					   may be passed */
 > +    ARG_LAST_REGNUM = H8300_R3_REGNUM,	/* last  reg in which an arg 
 > +					   may be passed */
 > +    H8300_FP_REGNUM = H8300_R6_REGNUM,	/* Contain address of executing 
 > +					   stack frame */
 > +    H8300_SP_REGNUM = H8300_R7_REGNUM	/* Contains address of top of stack
 > */
 > +  };
 > +
 > +  enum
 > +  {
 > +    H8300_S_EXR_REGNUM = H8300_NUM_COMMON_REGS,	/* Contains extended
 > 
 > +					           processor status  */
 > +    H8300_S_MACL_REGNUM,	/* Lower part of MAC register */
 > +    H8300_S_MACH_REGNUM,	/* High part of MAC register */
 > +
 > +    H8300_S_NUM_REGS
 > +  };
 > +
 > +  enum
 > +  {
 > +    H8300_SYM_CYCLE_REGNUM = H8300_S_NUM_REGS,
 > +    H8300_SYM_INST_REGNUM,
 > +    H8300_SYM_TICK_REGNUM,
 > +
 > +    H8300_SYM_NUM_REGS
 > +  };
 > +   
 > +#ifdef __cplusplus
 > +}
 > +#endif
 > + 
 > +#endif				/* SIM_H8300_H */