From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
To: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [RFAv2] Implement show | set may-call-functions [on|off]
Date: Sat, 27 Apr 2019 11:38:00 -0000 [thread overview]
Message-ID: <1556365078.22002.17.camel@skynet.be> (raw)
In-Reply-To: <2c5a4158-8e42-8e01-82d0-7ea3b5f732f1@redhat.com>
On Sat, 2019-04-27 at 11:40 +0100, Pedro Alves wrote:
> On 4/26/19 10:34 PM, Philippe Waroquiers wrote:
> > Inferior function calls are powerful but might lead to undesired
> > results such as crashes when calling nested functions (frequently
> > used in particular in Ada).
> >
> > This implements a GDB setting to disable calling inferior functions.
> >
> > Note: the idea is that if/when the 'slash command' patch is pushed,
> > that this setting can be changed e.g. by using the shortcut /c.
> >
> > This is version 2 of the patch. It handles all the received comments,
> > mostly replace 'can-call' by 'may-call', and avoid using
> > 'inferior function call' in factor of 'calling function in the program'.
> >
>
> Thanks. I like this version a lot better.
>
> Some nits below. LGTM with those fixed.
Thanks for the reviews. Pushed after applying the fixes.
Philippe
prev parent reply other threads:[~2019-04-27 11:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 21:35 Philippe Waroquiers
2019-04-27 7:17 ` Eli Zaretskii
2019-04-27 10:40 ` Pedro Alves
2019-04-27 11:38 ` Philippe Waroquiers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1556365078.22002.17.camel@skynet.be \
--to=philippe.waroquiers@skynet.be \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox