From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115041 invoked by alias); 27 Apr 2019 11:38:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 115033 invoked by uid 89); 27 Apr 2019 11:38:04 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-12.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy=HTo:U*palves X-HELO: mailsec105.isp.belgacom.be Received: from mailsec105.isp.belgacom.be (HELO mailsec105.isp.belgacom.be) (195.238.20.101) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 27 Apr 2019 11:38:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skynet.be; i=@skynet.be; q=dns/txt; s=securemail; t=1556365080; x=1587901080; h=message-id:subject:from:to:date:in-reply-to:references: mime-version:content-transfer-encoding; bh=14uKaXUEyhCM8sjJW9SbrOMhUpyYXmSO4FtM6MXyHpc=; b=uLF6mCu8pa0V11uW2aTFlz0PqVeJKMtdqv9mZuwsjWBPpJSJi6EcnAaR GMwfXM9Mhm1l2wjdAIYlTh84A3Ky5g==; Received: from unknown (HELO md) ([109.129.151.59]) by relay.skynet.be with ESMTP/TLS/AES256-GCM-SHA384; 27 Apr 2019 13:37:58 +0200 Message-ID: <1556365078.22002.17.camel@skynet.be> Subject: Re: [RFAv2] Implement show | set may-call-functions [on|off] From: Philippe Waroquiers To: Pedro Alves , gdb-patches@sourceware.org Date: Sat, 27 Apr 2019 11:38:00 -0000 In-Reply-To: <2c5a4158-8e42-8e01-82d0-7ea3b5f732f1@redhat.com> References: <20190426213450.22345-1-philippe.waroquiers@skynet.be> <2c5a4158-8e42-8e01-82d0-7ea3b5f732f1@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-04/txt/msg00591.txt.bz2 On Sat, 2019-04-27 at 11:40 +0100, Pedro Alves wrote: > On 4/26/19 10:34 PM, Philippe Waroquiers wrote: > > Inferior function calls are powerful but might lead to undesired > > results such as crashes when calling nested functions (frequently > > used in particular in Ada). > > > > This implements a GDB setting to disable calling inferior functions. > > > > Note: the idea is that if/when the 'slash command' patch is pushed, > > that this setting can be changed e.g. by using the shortcut /c. > > > > This is version 2 of the patch. It handles all the received comments, > > mostly replace 'can-call' by 'may-call', and avoid using > > 'inferior function call' in factor of 'calling function in the program'. > > > > Thanks. I like this version a lot better. > > Some nits below. LGTM with those fixed. Thanks for the reviews. Pushed after applying the fixes. Philippe