From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
To: Kevin Buettner <kevinb@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] Fix internal error with 'set debug infrun 1' under high load
Date: Sun, 24 Mar 2019 21:40:00 -0000 [thread overview]
Message-ID: <1553463600.1504.5.camel@skynet.be> (raw)
In-Reply-To: <20190324143515.2463f3a3@f29-4.lan>
On Sun, 2019-03-24 at 14:35 -0700, Kevin Buettner wrote:
> You make a good point about trying to make use of ws.value.integer.
>
> So, here are my suggestions:
>
> 1) Move TARGET_WAITKIND_SIGNALLED into another "else if" clause. It
> doesn't make sense for the debug message to indicate that the process
> has exited when it's actually been signalled.
>
> 2) Make the TARGET_WAITKIND_THREAD_EXITED / TARGET_WAITKIND_EXITED
> case print the exit status and make the TARGET_WAITKIND_SIGNALLED case
> print the signal. These are available (respectively) in ws.value.integer and
> ws.value.sig.
Thanks for the feedback, I will (some time this week) prepare a patch
based on these suggestions.
Philippe
prev parent reply other threads:[~2019-03-24 21:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-24 14:25 Philippe Waroquiers
2019-03-24 20:50 ` Kevin Buettner
2019-03-24 21:09 ` Philippe Waroquiers
2019-03-24 21:35 ` Kevin Buettner
2019-03-24 21:40 ` Philippe Waroquiers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1553463600.1504.5.camel@skynet.be \
--to=philippe.waroquiers@skynet.be \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox