From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20903 invoked by alias); 24 Mar 2019 21:40:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20891 invoked by uid 89); 24 Mar 2019 21:40:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mailsec105.isp.belgacom.be Received: from mailsec105.isp.belgacom.be (HELO mailsec105.isp.belgacom.be) (195.238.20.101) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 24 Mar 2019 21:40:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skynet.be; i=@skynet.be; q=dns/txt; s=securemail; t=1553463602; x=1584999602; h=message-id:subject:from:to:date:in-reply-to:references: mime-version:content-transfer-encoding; bh=f0ehcN3XvA5yxGzozhWucoioiJ7f6KCMxGvBBDRnhhA=; b=I7oKhwa/6QPc5wWoWmGYK+MJATmeQak4l0PQYAH6Hw8kwRg3zTA64DhX YxLTqDm9keoQia5Brp8TQOqMxlhHvQ==; Received: from 147.122-130-109.adsl-dyn.isp.belgacom.be (HELO md) ([109.130.122.147]) by relay.skynet.be with ESMTP/TLS/AES256-GCM-SHA384; 24 Mar 2019 22:40:00 +0100 Message-ID: <1553463600.1504.5.camel@skynet.be> Subject: Re: [RFA] Fix internal error with 'set debug infrun 1' under high load From: Philippe Waroquiers To: Kevin Buettner , gdb-patches@sourceware.org Date: Sun, 24 Mar 2019 21:40:00 -0000 In-Reply-To: <20190324143515.2463f3a3@f29-4.lan> References: <20190324142505.27486-1-philippe.waroquiers@skynet.be> <20190324135043.043ef0d9@f29-4.lan> <1553461783.1504.3.camel@skynet.be> <20190324143515.2463f3a3@f29-4.lan> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00522.txt.bz2 On Sun, 2019-03-24 at 14:35 -0700, Kevin Buettner wrote: > You make a good point about trying to make use of ws.value.integer. > > So, here are my suggestions: > > 1) Move TARGET_WAITKIND_SIGNALLED into another "else if" clause. It > doesn't make sense for the debug message to indicate that the process > has exited when it's actually been signalled. > > 2) Make the TARGET_WAITKIND_THREAD_EXITED / TARGET_WAITKIND_EXITED > case print the exit status and make the TARGET_WAITKIND_SIGNALLED case > print the signal. These are available (respectively) in ws.value.integer and > ws.value.sig. Thanks for the feedback, I will (some time this week) prepare a patch based on these suggestions. Philippe