From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Fix leaks of 'per program space' and 'per inferior' ada task data.
Date: Mon, 18 Feb 2019 21:36:00 -0000 [thread overview]
Message-ID: <1550525804.1521.0.camel@skynet.be> (raw)
In-Reply-To: <87sgwmknb4.fsf@tromey.com>
On Sun, 2019-02-17 at 16:27 -0700, Tom Tromey wrote:
> > > > > > "Philippe" == Philippe Waroquiers <philippe.waroquiers@skynet.be> writes:
>
> Philippe> + if (data != NULL)
> Philippe> + XDELETE (data);
>
> gdb normally uses "xfree" and not XDELETE.
> Also the NULL check isn't needed.
>
> Philippe> + if (data != NULL)
> Philippe> + delete data;
>
> You don't need the NULL check here either.
>
> This is ok with these changes. Thank you for the patch.
Thanks for the review, pushed after having done the above fixes.
Philippe
prev parent reply other threads:[~2019-02-18 21:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-17 19:50 Philippe Waroquiers
2019-02-17 23:31 ` Tom Tromey
2019-02-18 21:36 ` Philippe Waroquiers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1550525804.1521.0.camel@skynet.be \
--to=philippe.waroquiers@skynet.be \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox