From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-154022-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 45546 invoked by alias); 18 Feb 2019 21:36:50 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 45526 invoked by uid 89); 18 Feb 2019 21:36:50 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mailsec113.isp.belgacom.be
Received: from mailsec113.isp.belgacom.be (HELO mailsec113.isp.belgacom.be) (195.238.20.109) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 18 Feb 2019 21:36:47 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;  d=skynet.be; i=@skynet.be; q=dns/txt; s=securemail;  t=1550525808; x=1582061808;  h=message-id:subject:from:to:cc:date:in-reply-to:   references:mime-version:content-transfer-encoding;  bh=+K/9Kt0D+5+vNgbT4F91h9R9npylkYohzRbXRqitrT8=;  b=ALR/2iJrklYn8x3pNkbIdMbHZGn/43ywc1snMkI1r5hsjz+O5Fl2+L7M   dAJAFrEL2Rs44XSKtg2NElZKgyg+1g==;
Received: from 147.122-130-109.adsl-dyn.isp.belgacom.be (HELO md) ([109.130.122.147])  by relay.skynet.be with ESMTP/TLS/AES256-GCM-SHA384; 18 Feb 2019 22:36:46 +0100
Message-ID: <1550525804.1521.0.camel@skynet.be>
Subject: Re: [RFA] Fix leaks of 'per program space' and 'per inferior' ada task data.
From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Date: Mon, 18 Feb 2019 21:36:00 -0000
In-Reply-To: <87sgwmknb4.fsf@tromey.com>
References: <20190217195037.25482-1-philippe.waroquiers@skynet.be>	 <87sgwmknb4.fsf@tromey.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2019-02/txt/msg00289.txt.bz2

On Sun, 2019-02-17 at 16:27 -0700, Tom Tromey wrote:
> > > > > > "Philippe" == Philippe Waroquiers <philippe.waroquiers@skynet.be> writes:
> 
> Philippe> +  if (data != NULL)
> Philippe> +    XDELETE (data);
> 
> gdb normally uses "xfree" and not XDELETE.
> Also the NULL check isn't needed.
> 
> Philippe> +  if (data != NULL)
> Philippe> +    delete data;
> 
> You don't need the NULL check here either.
> 
> This is ok with these changes.  Thank you for the patch.
Thanks for the review, pushed after having done the above fixes.

Philippe