From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
To: Eli Zaretskii <eliz@gnu.org>,
Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: NEWS entry for Changes to the "frame", "select-frame" ...
Date: Wed, 09 Jan 2019 21:41:00 -0000 [thread overview]
Message-ID: <1547070090.1500.8.camel@skynet.be> (raw)
In-Reply-To: <831s5p24bz.fsf@gnu.org>
On Sun, 2019-01-06 at 17:28 +0200, Eli Zaretskii wrote:
> > Date: Sun, 6 Jan 2019 10:46:36 +0000
> > From: Andrew Burgess <andrew.burgess@embecosm.com>
> > Cc: gdb-patches <gdb-patches@sourceware.org>
> >
> > * Philippe Waroquiers <philippe.waroquiers@skynet.be> [2019-01-04 21:34:31 +0100]:
> >
> > > The below paragraph is at an unusual place in NEWS,
> > > as new and changed commands are normally documented in the sections
> > > * New commands
> > > or
> > > * Changed commands.
> > >
> > > Maybe it should be reworded and moved to these 2 sections ?
> > >
> > > Philippe
> > >
> > > * Changes to the "frame", "select-frame", and "info frame" CLI
> > >  commands.  These commands all now take a frame specification which
> > > Â is either a frame level, or one of the keywords 'level', 'address',
> > >  'function', or 'view' followed by a parameter.  Selecting a frame by
> > > Â address, or viewing a frame outside the current backtrace now
> > >  requires the use of a keyword.  Selecting a frame by level is
> > >  unchanged.  The MI comment "-stack-select-frame" is unchanged.
> >
> > This is fine with me (as the original author), but you'll need a
> > maintainer to OK the change too.
>
> I'm OK with moving this to the "Changed commands" section.
>
> Thanks.
Thanks for the feedback.
I pushed the below change.
Philippe
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 1c20afc8a8..2e9c2f2e5a 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
+
+Â Â Â Â Â Â Â * NEWS: Move the description of the changed "frame", "select-frame",
+Â Â Â Â Â Â Â Â and "info frame" commands to the Changed commands section.
+
 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
Â
        * gdbtypes.c (check_stub_method_group): Remove handling of old
diff --git a/gdb/NEWS b/gdb/NEWS
index 14c859f8f6..eaef6aa384 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -30,14 +30,6 @@
 * GDB in batch mode now exits with status 1 if the last command to be
   executed failed.
Â
-* Changes to the "frame", "select-frame", and "info frame" CLI
-  commands.  These commands all now take a frame specification which
-Â Â is either a frame level, or one of the keywords 'level', 'address',
-  'function', or 'view' followed by a parameter.  Selecting a frame by
-Â Â address, or viewing a frame outside the current backtrace now
-  requires the use of a keyword.  Selecting a frame by level is
-  unchanged.  The MI comment "-stack-select-frame" is unchanged.
-
 * The RISC-V target now supports target descriptions.
Â
 * System call catchpoints now support system call aliases on FreeBSD.
@@ -106,6 +98,14 @@ info proc files
Â
 * Changed commands
Â
+Changes to the "frame", "select-frame", and "info frame" CLI commands.
+Â Â These commands all now take a frame specification which
+Â Â is either a frame level, or one of the keywords 'level', 'address',
+  'function', or 'view' followed by a parameter.  Selecting a frame by
+Â Â address, or viewing a frame outside the current backtrace now
+  requires the use of a keyword.  Selecting a frame by level is
+  unchanged.  The MI comment "-stack-select-frame" is unchanged.
+
 target remote FILENAME
 target extended-remote FILENAME
   If FILENAME is a Unix domain socket, GDB will attempt to connect
prev parent reply other threads:[~2019-01-09 21:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 20:34 Philippe Waroquiers
2019-01-06 10:46 ` Andrew Burgess
2019-01-06 15:28 ` Eli Zaretskii
2019-01-09 21:41 ` Philippe Waroquiers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1547070090.1500.8.camel@skynet.be \
--to=philippe.waroquiers@skynet.be \
--cc=andrew.burgess@embecosm.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox