From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Fix 'Invalid read of size 4' in search_command_helper
Date: Tue, 01 Jan 2019 19:35:00 -0000 [thread overview]
Message-ID: <1546371352.12900.24.camel@skynet.be> (raw)
In-Reply-To: <87pntgjkaw.fsf@tromey.com>
On Tue, 2019-01-01 at 11:37 -0700, Tom Tromey wrote:
> > > > > > "Philippe" == Philippe Waroquiers <philippe.waroquiers@skynet.be> writes:
>
> Philippe> gdb/ChangeLog
> Philippe> 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
>
> Philippe> * source.c (search_command_helper): Stop reverse search
> Philippe> when line 1 has been searched.
>
> This is ok. Some of these could probably have gone in under the obvious
> rule, though I completely understand if you'd rather not do that.
Effectively, some fixes are easy enough to be obvious, but still sometimes
an explicit review helps to see e.g. when it is time to restructure
the code (e.g. to restructure it using c++).
Thanks for the reviews, I pushed all 3 RFA fixes.
Philippe
prev parent reply other threads:[~2019-01-01 19:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-01 15:02 Philippe Waroquiers
2019-01-01 18:37 ` Tom Tromey
2019-01-01 19:35 ` Philippe Waroquiers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1546371352.12900.24.camel@skynet.be \
--to=philippe.waroquiers@skynet.be \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox