From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60680 invoked by alias); 1 Jan 2019 19:35:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 60671 invoked by uid 89); 1 Jan 2019 19:35:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:813 X-HELO: mailsec111.isp.belgacom.be Received: from mailsec111.isp.belgacom.be (HELO mailsec111.isp.belgacom.be) (195.238.20.107) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 01 Jan 2019 19:35:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skynet.be; i=@skynet.be; q=dns/txt; s=securemail; t=1546371355; x=1577907355; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=5jzaKqXIwDuEGkhawsH19SQWqivza3eC5l1TwiP/m2w=; b=N8oFRdYcfbXBYFHHCcQj/MDqvDQqyzbjTFTYg/19OLNU5Wkj4XZQJzuc hCvIMYFSqqEL2Ttq4hf1z62BWf/JQA==; Received: from 184.205-67-87.adsl-dyn.isp.belgacom.be (HELO md) ([87.67.205.184]) by relay.skynet.be with ESMTP/TLS/AES256-GCM-SHA384; 01 Jan 2019 20:35:52 +0100 Message-ID: <1546371352.12900.24.camel@skynet.be> Subject: Re: [RFA] Fix 'Invalid read of size 4' in search_command_helper From: Philippe Waroquiers To: Tom Tromey Cc: gdb-patches@sourceware.org Date: Tue, 01 Jan 2019 19:35:00 -0000 In-Reply-To: <87pntgjkaw.fsf@tromey.com> References: <20190101150151.3177-1-philippe.waroquiers@skynet.be> <87pntgjkaw.fsf@tromey.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg00010.txt.bz2 On Tue, 2019-01-01 at 11:37 -0700, Tom Tromey wrote: > > > > > > "Philippe" == Philippe Waroquiers writes: > > Philippe> gdb/ChangeLog > Philippe> 2019-01-01 Philippe Waroquiers > > Philippe> * source.c (search_command_helper): Stop reverse search > Philippe> when line 1 has been searched. > > This is ok. Some of these could probably have gone in under the obvious > rule, though I completely understand if you'd rather not do that. Effectively, some fixes are easy enough to be obvious, but still sometimes an explicit review helps to see e.g. when it is time to restructure the code (e.g. to restructure it using c++). Thanks for the reviews, I pushed all 3 RFA fixes. Philippe