Re: [RFA] new tcp_open

[Elena Zannoni <ezannoni@cygnus.com>]

Martin, I am getting these warnings on solaris (with ,-Werror):


cc1: warnings being treated as errors
/es/scratch/ezannoni/uberbaum/src/gdb/ser-tcp.c: In function `tcp_open':
/es/scratch/ezannoni/uberbaum/src/gdb/ser-tcp.c:154: warning: passing arg 4 of `getsockopt' from incompatible pointer type
make: *** [ser-tcp.o] Error 1

Elena


Martin M. Hunt writes:
 > Checked in.
 > 
 > Martin
 > 
 > On Tuesday 18 December 2001 03:21 am, Andrew Cagney wrote:
 > > > Please give this patch a try and see if it fixes the problem.
 > > >
 > > > Index: ser-tcp.c
 > > > ===================================================================
 > > > RCS file: /cvs/src/src/gdb/ser-tcp.c,v
 > > > retrieving revision 1.9
 > > > diff -u -p -r1.9 ser-tcp.c
 > > > --- ser-tcp.c   2001/12/07 17:57:05     1.9
 > > > +++ ser-tcp.c   2001/12/18 10:54:31
 > > > @@ -165,6 +165,10 @@ tcp_open (struct serial *scb, const char
 > > >    tmp = 0;
 > > >    ioctl (scb->fd, FIONBIO, &tmp);
 > > >
 > > > +  tmp = 1;
 > > > +  setsockopt (scb->fd, IPPROTO_TCP, TCP_NODELAY,
 > > > +             (char *)&tmp, sizeof (tmp));
 > > > +
 > > >    /* If we don't do this, then GDB simply exits
 > > >       when the remote side dies.  */
 > > >    signal (SIGPIPE, SIG_IGN);
 > >
 > > If it does, feel free to check it, and any other related changes in :-)
 > >
 > >
 > > Andrew