From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-11424-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 6588 invoked by alias); 19 Dec 2001 23:32:45 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 6567 invoked from network); 19 Dec 2001 23:32:44 -0000
Received: from unknown (HELO cygnus.com) (205.180.230.5)
  by sources.redhat.com with SMTP; 19 Dec 2001 23:32:44 -0000
Received: from rtl.cygnus.com (cse.cygnus.com [205.180.230.236])
	by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id PAA28088;
	Wed, 19 Dec 2001 15:32:35 -0800 (PST)
Received: (from ezannoni@localhost)
	by rtl.cygnus.com (8.11.2/8.11.0) id fBJMjSa03011;
	Wed, 19 Dec 2001 17:45:28 -0500
X-Authentication-Warning: localhost.localdomain: ezannoni set sender to ezannoni@cygnus.com using -f
From: Elena Zannoni <ezannoni@cygnus.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <15393.6280.385863.67517@localhost.localdomain>
Date: Wed, 19 Dec 2001 15:32:00 -0000
To: "Martin M. Hunt" <hunt@redhat.com>
Cc: Andrew Cagney <ac131313@cygnus.com>,
        Orjan Friberg <orjan.friberg@axis.com>, gdb-patches@sources.redhat.com
Subject: Re: [RFA] new tcp_open
In-Reply-To: <200112182028.MAA25648@cygnus.com>
References: <200112031918.LAA18199@cygnus.com>
	<200112181056.CAA08011@cygnus.com>
	<3C1F26D7.30003@cygnus.com>
	<200112182028.MAA25648@cygnus.com>
X-Mailer: VM 7.00 under Emacs 20.7.1
X-SW-Source: 2001-12/txt/msg00491.txt.bz2


Martin, I am getting these warnings on solaris (with ,-Werror):


cc1: warnings being treated as errors
/es/scratch/ezannoni/uberbaum/src/gdb/ser-tcp.c: In function `tcp_open':
/es/scratch/ezannoni/uberbaum/src/gdb/ser-tcp.c:154: warning: passing arg 4 of `getsockopt' from incompatible pointer type
make: *** [ser-tcp.o] Error 1

Elena


Martin M. Hunt writes:
 > Checked in.
 > 
 > Martin
 > 
 > On Tuesday 18 December 2001 03:21 am, Andrew Cagney wrote:
 > > > Please give this patch a try and see if it fixes the problem.
 > > >
 > > > Index: ser-tcp.c
 > > > ===================================================================
 > > > RCS file: /cvs/src/src/gdb/ser-tcp.c,v
 > > > retrieving revision 1.9
 > > > diff -u -p -r1.9 ser-tcp.c
 > > > --- ser-tcp.c   2001/12/07 17:57:05     1.9
 > > > +++ ser-tcp.c   2001/12/18 10:54:31
 > > > @@ -165,6 +165,10 @@ tcp_open (struct serial *scb, const char
 > > >    tmp = 0;
 > > >    ioctl (scb->fd, FIONBIO, &tmp);
 > > >
 > > > +  tmp = 1;
 > > > +  setsockopt (scb->fd, IPPROTO_TCP, TCP_NODELAY,
 > > > +             (char *)&tmp, sizeof (tmp));
 > > > +
 > > >    /* If we don't do this, then GDB simply exits
 > > >       when the remote side dies.  */
 > > >    signal (SIGPIPE, SIG_IGN);
 > >
 > > If it does, feel free to check it, and any other related changes in :-)
 > >
 > >
 > > Andrew