Allow current CVS libbfd to build with cc on Tru64 UNIX V5.1

Allow current CVS libbfd to build with cc on Tru64 UNIX V5.1

[Rainer Orth]

Trying to build the current CVS gdb on alpha-dec-osf5.1 with Compaq C (cc),
I failed initially:

cc: Warning: /vol/gnu/src/gdb/src/bfd/coff-alpha.c, line 2273: In the initializer for alpha_ecoff_backend_data.coff._bfd_styp_to_sec_flags_hook, the referenced type of the pointer value "_bfd_ecoff_styp_to_sec_flags" is "function (pointer to struct _bfd, pointer to void, pointer to const char, pointer to struct sec, pointer to unsigned int) returning unsigned int", which is not compatible with "function (pointer to struct _bfd, pointer to void, pointer to const char, pointer to struct sec, pointer to unsigned int) returning enum bfd_boolean". (ptrmismatch)
    alpha_ecoff_mkobject_hook, _bfd_ecoff_styp_to_sec_flags,
-------------------------------^
cc: Error: /vol/gnu/src/gdb/src/bfd/ecoff.c, line 375: In this declaration, the type of "_bfd_ecoff_styp_to_sec_flags" is not compatible with the type of a previous declaration of "_bfd_ecoff_styp_to_sec_flags" at line number 343 in file /vol/gnu/src/gdb/src/bfd/libecoff.h. (notcompat)
_bfd_ecoff_styp_to_sec_flags (abfd, hdr, name, section, flags_ptr)
^

The following trivial patch fixes this.

	Rainer

-----------------------------------------------------------------------------
Rainer Orth, Faculty of Technology, Bielefeld University

Email: ro@TechFak.Uni-Bielefeld.DE


Fri Jul 27 20:35:36 2001  Rainer Orth  <ro@TechFak.Uni-Bielefeld.DE>

	* libecoff.h (_bfd_ecoff_styp_to_sec_flags): Changed return type
	to match corresponding bfd_coff_backend data member.

Index: bfd/libecoff.h
===================================================================
RCS file: /cvs/src/src/bfd/libecoff.h,v
retrieving revision 1.6
diff -u -p -r1.6 libecoff.h
--- libecoff.h	2001/06/15 09:03:13	1.6
+++ libecoff.h	2001/07/27 18:56:53
@@ -340,7 +340,7 @@ extern PTR _bfd_ecoff_mkobject_hook PARA
 #define _bfd_ecoff_set_alignment_hook \
   ((void (*) PARAMS ((bfd *, asection *, PTR))) bfd_void)
 extern boolean _bfd_ecoff_set_arch_mach_hook PARAMS ((bfd *abfd, PTR filehdr));
-extern flagword _bfd_ecoff_styp_to_sec_flags
+extern boolean _bfd_ecoff_styp_to_sec_flags
   PARAMS ((bfd *, PTR, const char *, asection *, flagword *));
 extern boolean _bfd_ecoff_slurp_symbol_table PARAMS ((bfd *abfd));
 

Re: Allow current CVS libbfd to build with cc on Tru64 UNIX V5.1

[Michael Snyder]

Rainer Orth wrote:
> 
> Trying to build the current CVS gdb on alpha-dec-osf5.1 with Compaq C (cc),
> I failed initially:
> 
> cc: Warning: /vol/gnu/src/gdb/src/bfd/coff-alpha.c, line 2273: In the initializer for alpha_ecoff_backend_data.coff._bfd_styp_to_sec_flags_hook, the referenced type of the pointer value "_bfd_ecoff_styp_to_sec_flags" is "function (pointer to struct _bfd, pointer to void, pointer to const char, pointer to struct sec, pointer to unsigned int) returning unsigned int", which is not compatible with "function (pointer to struct _bfd, pointer to void, pointer to const char, pointer to struct sec, pointer to unsigned int) returning enum bfd_boolean". (ptrmismatch)
>     alpha_ecoff_mkobject_hook, _bfd_ecoff_styp_to_sec_flags,
> -------------------------------^
> cc: Error: /vol/gnu/src/gdb/src/bfd/ecoff.c, line 375: In this declaration, the type of "_bfd_ecoff_styp_to_sec_flags" is not compatible with the type of a previous declaration of "_bfd_ecoff_styp_to_sec_flags" at line number 343 in file /vol/gnu/src/gdb/src/bfd/libecoff.h. (notcompat)
> _bfd_ecoff_styp_to_sec_flags (abfd, hdr, name, section, flags_ptr)
> ^
> 
> The following trivial patch fixes this.

I think the change is good, but I'm not sure if this is 
the right mailing list for it.  Where do we send bfd changes?
To binutils?

				Michael

> 
>         Rainer
> 
> -----------------------------------------------------------------------------
> Rainer Orth, Faculty of Technology, Bielefeld University
> 
> Email: ro@TechFak.Uni-Bielefeld.DE
> 
> Fri Jul 27 20:35:36 2001  Rainer Orth  <ro@TechFak.Uni-Bielefeld.DE>
> 
>         * libecoff.h (_bfd_ecoff_styp_to_sec_flags): Changed return type
>         to match corresponding bfd_coff_backend data member.
> 
> Index: bfd/libecoff.h
> ===================================================================
> RCS file: /cvs/src/src/bfd/libecoff.h,v
> retrieving revision 1.6
> diff -u -p -r1.6 libecoff.h
> --- libecoff.h  2001/06/15 09:03:13     1.6
> +++ libecoff.h  2001/07/27 18:56:53
> @@ -340,7 +340,7 @@ extern PTR _bfd_ecoff_mkobject_hook PARA
>  #define _bfd_ecoff_set_alignment_hook \
>    ((void (*) PARAMS ((bfd *, asection *, PTR))) bfd_void)
>  extern boolean _bfd_ecoff_set_arch_mach_hook PARAMS ((bfd *abfd, PTR filehdr));
> -extern flagword _bfd_ecoff_styp_to_sec_flags
> +extern boolean _bfd_ecoff_styp_to_sec_flags
>    PARAMS ((bfd *, PTR, const char *, asection *, flagword *));
>  extern boolean _bfd_ecoff_slurp_symbol_table PARAMS ((bfd *abfd));
>

Re: Allow current CVS libbfd to build with cc on Tru64 UNIX V5.1

[Rainer Orth]

Michael Snyder writes:

> I think the change is good, but I'm not sure if this is 
> the right mailing list for it.  Where do we send bfd changes?
> To binutils?

I think binutils is right.  At least that's what I found in the toplevel
MAINTAINERS file.  That's why I've sent the patch there, with a copy to
gdb-patches since at the moment gdb on Tru64 UNIX was the affected program.

	Rainer

-----------------------------------------------------------------------------
Rainer Orth, Faculty of Technology, Bielefeld University

Email: ro@TechFak.Uni-Bielefeld.DE