Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [RFA] Add missing "reason" to print_stop_reason
@ 2001-07-11  8:16 Keith Seitz
  2001-07-11  9:30 ` Elena Zannoni
  0 siblings, 1 reply; 3+ messages in thread
From: Keith Seitz @ 2001-07-11  8:16 UTC (permalink / raw)
  To: gdb-patches

Hi,

Okay, I know that this is all due for some massaging, but this patch will
allow the workaround to work a little better until the formal mechanism is
in place.

Keith

ChangeLog:
2001-07-11  Keith Seitz  <keiths@redhat.com>

	* infrun.c (print_stop_reason): Add missing uiout field
	"reason" for SIGNAL_RECEIVED case.

Patch:
Index: infrun.c
===================================================================
RCS file: /cvs/src/src/gdb/infrun.c,v
retrieving revision 1.42
diff -u -p -r1.42 infrun.c
--- infrun.c	2001/07/06 03:53:11	1.42
+++ infrun.c	2001/07/11 15:14:25
@@ -3382,6 +3382,8 @@ print_stop_reason (enum inferior_stop_re
       annotate_signal ();
       ui_out_text (uiout, "\nProgram received signal ");
       annotate_signal_name ();
+      if (ui_out_is_mi_like_p (uiout))
+	ui_out_field_string (uiout, "reason", "signal-received");
       ui_out_field_string (uiout, "signal-name", target_signal_to_name (stop_info));
       annotate_signal_name_end ();
       ui_out_text (uiout, ", ");



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RFA] Add missing "reason" to print_stop_reason
  2001-07-11  8:16 [RFA] Add missing "reason" to print_stop_reason Keith Seitz
@ 2001-07-11  9:30 ` Elena Zannoni
  2001-07-11  9:41   ` Andrew Cagney
  0 siblings, 1 reply; 3+ messages in thread
From: Elena Zannoni @ 2001-07-11  9:30 UTC (permalink / raw)
  To: Keith Seitz; +Cc: gdb-patches

I don't have power to approve this because I don't maintain infrun.c,
but since I wrote print_stop_reason, I recommend the patch for approval. 

Elena


Keith Seitz writes:
 > Hi,
 > 
 > Okay, I know that this is all due for some massaging, but this patch will
 > allow the workaround to work a little better until the formal mechanism is
 > in place.
 > 
 > Keith
 > 
 > ChangeLog:
 > 2001-07-11  Keith Seitz  <keiths@redhat.com>
 > 
 > 	* infrun.c (print_stop_reason): Add missing uiout field
 > 	"reason" for SIGNAL_RECEIVED case.
 > 
 > Patch:
 > Index: infrun.c
 > ===================================================================
 > RCS file: /cvs/src/src/gdb/infrun.c,v
 > retrieving revision 1.42
 > diff -u -p -r1.42 infrun.c
 > --- infrun.c	2001/07/06 03:53:11	1.42
 > +++ infrun.c	2001/07/11 15:14:25
 > @@ -3382,6 +3382,8 @@ print_stop_reason (enum inferior_stop_re
 >        annotate_signal ();
 >        ui_out_text (uiout, "\nProgram received signal ");
 >        annotate_signal_name ();
 > +      if (ui_out_is_mi_like_p (uiout))
 > +	ui_out_field_string (uiout, "reason", "signal-received");
 >        ui_out_field_string (uiout, "signal-name", target_signal_to_name (stop_info));
 >        annotate_signal_name_end ();
 >        ui_out_text (uiout, ", ");
 > 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RFA] Add missing "reason" to print_stop_reason
  2001-07-11  9:30 ` Elena Zannoni
@ 2001-07-11  9:41   ` Andrew Cagney
  0 siblings, 0 replies; 3+ messages in thread
From: Andrew Cagney @ 2001-07-11  9:41 UTC (permalink / raw)
  To: Elena Zannoni; +Cc: Keith Seitz, gdb-patches

> I don't have power to approve this because I don't maintain infrun.c,
> but since I wrote print_stop_reason, I recommend the patch for approval. 


I think it is pretty obvious (yes, ok).

	Andrew


> Keith Seitz writes:
>  > Hi,
>  > > Okay, I know that this is all due for some massaging, but this patch will
>  > allow the workaround to work a little better until the formal mechanism is
>  > in place.
>  > > Keith
>  > > ChangeLog:
>  > 2001-07-11  Keith Seitz  <keiths@redhat.com>
>> > * infrun.c (print_stop_reason): Add missing uiout field
>  > "reason" for SIGNAL_RECEIVED case.
>  > > Patch:
>  > Index: infrun.c
>  > ===================================================================
>  > RCS file: /cvs/src/src/gdb/infrun.c,v
>  > retrieving revision 1.42
>  > diff -u -p -r1.42 infrun.c
>  > --- infrun.c	2001/07/06 03:53:11	1.42
>  > +++ infrun.c	2001/07/11 15:14:25
>  > @@ -3382,6 +3382,8 @@ print_stop_reason (enum inferior_stop_re
>  > annotate_signal ();
>  > ui_out_text (uiout, "\nProgram received signal ");
>  > annotate_signal_name ();
>  > +      if (ui_out_is_mi_like_p (uiout))
>  > +	ui_out_field_string (uiout, "reason", "signal-received");
>  > ui_out_field_string (uiout, "signal-name", target_signal_to_name (stop_info));
>  > annotate_signal_name_end ();
>  > ui_out_text (uiout, ", ");
>  > 
> 



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2001-07-11  9:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-07-11  8:16 [RFA] Add missing "reason" to print_stop_reason Keith Seitz
2001-07-11  9:30 ` Elena Zannoni
2001-07-11  9:41   ` Andrew Cagney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox