From: Markus Metzger <markus.t.metzger@intel.com>
To: gdb-patches@sourceware.org
Subject: [PATCH v2 0/7] improve btrace enable error reporting
Date: Fri, 26 Jan 2018 14:14:00 -0000 [thread overview]
Message-ID: <1516976072-19282-1-git-send-email-markus.t.metzger@intel.com> (raw)
Recording may fail for a variety of reasons. Improve the error
messages by stating more clearly what operation failed and try to give
a reason why it failed.
Further align the error messages for native and remote debugging.
Changes to v1:
- move helper classes into gdb/common/
- add unit tests for helpers
- simplify helpers
Markus Metzger (7):
common: add scoped_fd
common: add scoped_mmap
btrace: prepare for throwing exceptions when enabling btrace
btrace, gdbserver: use exceptions to convey btrace enable/disable
errors
btrace, gdbserver: remove the to_supports_btrace target method
btrace: improve enable error messages
btrace: check perf_event_paranoid
gdb/Makefile.in | 2 +
gdb/btrace.c | 3 -
gdb/common/scoped_fd.h | 60 +++++
gdb/common/scoped_mmap.h | 76 ++++++
gdb/gdbserver/linux-low.c | 2 -
gdb/gdbserver/nto-low.c | 1 -
gdb/gdbserver/server.c | 80 +++----
gdb/gdbserver/spu-low.c | 1 -
gdb/gdbserver/target.h | 7 -
gdb/gdbserver/win32-low.c | 1 -
gdb/nat/linux-btrace.c | 427 ++++++++--------------------------
gdb/nat/linux-btrace.h | 3 -
gdb/remote.c | 32 ---
gdb/target-delegates.c | 33 ---
gdb/target.c | 8 -
gdb/target.h | 7 -
gdb/unittests/scoped_fd-selftests.c | 90 +++++++
gdb/unittests/scoped_mmap-selftests.c | 92 ++++++++
gdb/x86-linux-nat.c | 20 +-
19 files changed, 458 insertions(+), 487 deletions(-)
create mode 100644 gdb/common/scoped_fd.h
create mode 100644 gdb/common/scoped_mmap.h
create mode 100644 gdb/unittests/scoped_fd-selftests.c
create mode 100644 gdb/unittests/scoped_mmap-selftests.c
--
1.8.3.1
next reply other threads:[~2018-01-26 14:14 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-26 14:14 Markus Metzger [this message]
2018-01-26 14:14 ` [PATCH v2 2/7] common: add scoped_mmap Markus Metzger
2018-01-26 14:14 ` [PATCH v2 6/7] btrace: improve enable error messages Markus Metzger
2018-01-26 14:14 ` [PATCH v2 4/7] btrace, gdbserver: use exceptions to convey btrace enable/disable errors Markus Metzger
2018-01-26 14:14 ` [PATCH v2 5/7] btrace, gdbserver: remove the to_supports_btrace target method Markus Metzger
2018-02-24 16:51 ` Maciej W. Rozycki
2018-02-26 13:08 ` Metzger, Markus T
2018-02-26 19:30 ` Andreas Arnez
2018-02-26 21:58 ` Maciej W. Rozycki
2018-02-27 10:57 ` Metzger, Markus T
2018-02-27 15:32 ` Maciej W. Rozycki
2018-02-27 18:14 ` Metzger, Markus T
2018-02-28 10:29 ` Maciej W. Rozycki
2018-02-28 11:09 ` Maciej W. Rozycki
2018-02-28 11:24 ` Metzger, Markus T
2018-02-28 12:53 ` Metzger, Markus T
2018-02-28 15:55 ` Maciej W. Rozycki
2018-02-28 16:08 ` Eli Zaretskii
2018-02-28 12:00 ` Yao Qi
2018-02-28 16:27 ` Sergio Durigan Junior
2018-03-01 11:33 ` Metzger, Markus T
2018-03-01 19:27 ` Sergio Durigan Junior
2018-03-05 12:14 ` Yao Qi
[not found] ` <87lgf64i24.fsf@redhat.com>
2018-03-06 9:02 ` Yao Qi
2018-03-06 16:32 ` Sergio Durigan Junior
2018-03-01 19:34 ` Maciej W. Rozycki
2018-01-26 14:14 ` [PATCH v2 3/7] btrace: prepare for throwing exceptions when enabling btrace Markus Metzger
2018-01-26 14:14 ` [PATCH v2 1/7] common: add scoped_fd Markus Metzger
2018-02-13 16:48 ` Yao Qi
2018-02-13 17:28 ` Metzger, Markus T
2018-02-14 15:22 ` Yao Qi
2018-02-14 17:26 ` Metzger, Markus T
2018-02-19 15:28 ` Metzger, Markus T
2018-02-20 10:12 ` Yao Qi
2018-02-20 10:46 ` Metzger, Markus T
2018-02-06 16:28 ` [PATCH v2 0/7] improve btrace enable error reporting Pedro Alves
2018-02-07 10:41 ` Metzger, Markus T
2018-02-07 12:11 ` Pedro Alves
2018-02-08 10:40 ` Metzger, Markus T
[not found] ` <9ce0c90a-5c71-0a7d-3779-f826369a95ec@redhat.com>
2018-02-08 13:49 ` Metzger, Markus T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516976072-19282-1-git-send-email-markus.t.metzger@intel.com \
--to=markus.t.metzger@intel.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox