Re: [RFA] Fix "info func" display for 64-bit minimal symbols

Re: [RFA] Fix "info func" display for 64-bit minimal symbols

[Elena Zannoni]

Was this checked in? 
If not, go ahead.

Thanks
Elena



Michael Snyder writes:
 > This is a resubmission of a patch I sent several months ago, 
 > incorporating feedback.2001-04-17  Michael Snyder  <msnyder@redhat.com>
 > 
 > 	* symtab.c (print_msymbol_info): Allow for 64-bit addresses.
 > 
 > Index: symtab.c
 > ===================================================================
 > RCS file: /cvs/src/src/gdb/symtab.c,v
 > retrieving revision 1.34
 > diff -c -3 -p -r1.34 symtab.c
 > *** symtab.c	2001/04/01 19:50:50	1.34
 > --- symtab.c	2001/04/17 21:45:53
 > *************** print_symbol_info (namespace_enum kind, 
 > *** 2660,2668 ****
 >   static void
 >   print_msymbol_info (struct minimal_symbol *msymbol)
 >   {
 > !   printf_filtered ("	%08lx  %s\n",
 > ! 		   (unsigned long) SYMBOL_VALUE_ADDRESS (msymbol),
 > ! 		   SYMBOL_SOURCE_NAME (msymbol));
 >   }
 >   
 >   /* This is the guts of the commands "info functions", "info types", and
 > --- 2660,2676 ----
 >   static void
 >   print_msymbol_info (struct minimal_symbol *msymbol)
 >   {
 > !   char *tmp;
 > ! 
 > !   if (TARGET_ADDR_BIT <= 32)
 > !     tmp = longest_local_hex_string_custom (SYMBOL_VALUE_ADDRESS (msymbol)
 > ! 					   & (CORE_ADDR) 0xffffffff,
 > ! 					   "08l");
 > !   else
 > !     tmp = longest_local_hex_string_custom (SYMBOL_VALUE_ADDRESS (msymbol),
 > ! 					   "016l");
 > !   printf_filtered ("%s  %s\n",
 > ! 		   tmp, SYMBOL_SOURCE_NAME (msymbol));
 >   }
 >   
 >   /* This is the guts of the commands "info functions", "info types", and

Re: [RFA] Fix "info func" display for 64-bit minimal symbols

[Michael Snyder]

Elena Zannoni wrote:
> 
> Was this checked in?
> If not, go ahead.

OK, thanks.

> 
> Michael Snyder writes:
>  > This is a resubmission of a patch I sent several months ago,
>  > incorporating feedback.2001-04-17  Michael Snyder  <msnyder@redhat.com>
>  >
>  >      * symtab.c (print_msymbol_info): Allow for 64-bit addresses.
>  >
>  > Index: symtab.c
>  > ===================================================================
>  > RCS file: /cvs/src/src/gdb/symtab.c,v
>  > retrieving revision 1.34
>  > diff -c -3 -p -r1.34 symtab.c
>  > *** symtab.c 2001/04/01 19:50:50     1.34
>  > --- symtab.c 2001/04/17 21:45:53
>  > *************** print_symbol_info (namespace_enum kind,
>  > *** 2660,2668 ****
>  >   static void
>  >   print_msymbol_info (struct minimal_symbol *msymbol)
>  >   {
>  > !   printf_filtered ("       %08lx  %s\n",
>  > !               (unsigned long) SYMBOL_VALUE_ADDRESS (msymbol),
>  > !               SYMBOL_SOURCE_NAME (msymbol));
>  >   }
>  >
>  >   /* This is the guts of the commands "info functions", "info types", and
>  > --- 2660,2676 ----
>  >   static void
>  >   print_msymbol_info (struct minimal_symbol *msymbol)
>  >   {
>  > !   char *tmp;
>  > !
>  > !   if (TARGET_ADDR_BIT <= 32)
>  > !     tmp = longest_local_hex_string_custom (SYMBOL_VALUE_ADDRESS (msymbol)
>  > !                                       & (CORE_ADDR) 0xffffffff,
>  > !                                       "08l");
>  > !   else
>  > !     tmp = longest_local_hex_string_custom (SYMBOL_VALUE_ADDRESS (msymbol),
>  > !                                       "016l");
>  > !   printf_filtered ("%s  %s\n",
>  > !               tmp, SYMBOL_SOURCE_NAME (msymbol));
>  >   }
>  >
>  >   /* This is the guts of the commands "info functions", "info types", and