Re: [PATCH] gdb.btrace/*.exp: Make test names unique

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2016-10-07 03:42, Metzger, Markus T wrote:
>> -----Original Message-----
>> From: Simon Marchi [mailto:simon.marchi@ericsson.com]
>> Sent: Thursday, October 6, 2016 4:32 PM
>> To: Metzger, Markus T <markus.t.metzger@intel.com>; gdb-
>> patches@sourceware.org
>> Subject: Re: [PATCH] gdb.btrace/*.exp: Make test names unique
> 
> Hi Simon,
> 
>> >> This patch makes the btrace test names unique.  I was trying to
>> >> understand why rn-dl-bind.exp fails on my machine, and saw that it
>> >> failed at test "next".  Given that there are multiple "next" in that
>> >> test, it's hard to know which one doesn't work.
> [...]
>> Here's the gdb.log, if it can help you.
>> 
>> http://paste.ubuntu.com/23284745/
> 
> Thanks for sharing the log.  It does help.
> 
> You don't have debug information installed, which makes things more
> difficult for GDB.  The current tail-call detection heuristic is too 
> aggressive
> if there are no symbols available.
> 
> I posted a patch some time ago to make it less aggressive in this case:
> https://sourceware.org/ml/gdb-patches/2016-07/msg00277.html
> 
> This fixes (or hides, if you prefer) the issue you're seeing.  I don't 
> want to
> rule out that there might be other cases where we get the call stack 
> wrong
> if we don't have symbols available.
> 
> Let me ping again for this patch series.

Ok.

I have libc's debug symbols installed in /usr/lib/debug, but by default 
(without any --prefix) gdb looks in /usr/local/lib/debug, so it doesn't 
find it.  If I add a "set debug-file-directory /usr/lib/debug" at the 
beginning of the test, it passes.  It also passes with your patch 
series.

I will send a v2 of this patch when I have some free time.

Thanks!