From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21737 invoked by alias); 7 Oct 2016 13:04:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21726 invoked by uid 89); 7 Oct 2016 13:04:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=H*r:112, Hx-languages-length:1741 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 07 Oct 2016 13:04:17 +0000 Received: by simark.ca (Postfix, from userid 112) id 07C871E80D; Fri, 7 Oct 2016 09:04:16 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id BB9931E052; Fri, 7 Oct 2016 09:04:11 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 07 Oct 2016 13:04:00 -0000 From: Simon Marchi To: "Metzger, Markus T" Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb.btrace/*.exp: Make test names unique In-Reply-To: References: <20161003191729.1412-1-simon.marchi@ericsson.com> <1b86240b-3c1e-fdfe-6386-3f99f52e490c@ericsson.com> Message-ID: <14c7b2a9e5600081174e94268de433f4@simark.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.0 X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg00165.txt.bz2 On 2016-10-07 03:42, Metzger, Markus T wrote: >> -----Original Message----- >> From: Simon Marchi [mailto:simon.marchi@ericsson.com] >> Sent: Thursday, October 6, 2016 4:32 PM >> To: Metzger, Markus T ; gdb- >> patches@sourceware.org >> Subject: Re: [PATCH] gdb.btrace/*.exp: Make test names unique > > Hi Simon, > >> >> This patch makes the btrace test names unique. I was trying to >> >> understand why rn-dl-bind.exp fails on my machine, and saw that it >> >> failed at test "next". Given that there are multiple "next" in that >> >> test, it's hard to know which one doesn't work. > [...] >> Here's the gdb.log, if it can help you. >> >> http://paste.ubuntu.com/23284745/ > > Thanks for sharing the log. It does help. > > You don't have debug information installed, which makes things more > difficult for GDB. The current tail-call detection heuristic is too > aggressive > if there are no symbols available. > > I posted a patch some time ago to make it less aggressive in this case: > https://sourceware.org/ml/gdb-patches/2016-07/msg00277.html > > This fixes (or hides, if you prefer) the issue you're seeing. I don't > want to > rule out that there might be other cases where we get the call stack > wrong > if we don't have symbols available. > > Let me ping again for this patch series. Ok. I have libc's debug symbols installed in /usr/lib/debug, but by default (without any --prefix) gdb looks in /usr/local/lib/debug, so it doesn't find it. If I add a "set debug-file-directory /usr/lib/debug" at the beginning of the test, it passes. It also passes with your patch series. I will send a v2 of this patch when I have some free time. Thanks!