From: Ben Elliston <bje@redhat.com>
To: Andrew Cagney <ac131313@cygnus.com>
Cc: cgd@broadcom.com, gdb-patches@sources.redhat.com
Subject: Re: [MIPS sim patch] sim_monitor cleanup
Date: Mon, 19 Feb 2001 12:12:00 -0000 [thread overview]
Message-ID: <14993.32286.16403.330031@scooby.cygnus.com> (raw)
In-Reply-To: <3A916F98.FB189897@cygnus.com>
>>>>> "Andrew" == Andrew Cagney <ac131313@cygnus.com> writes:
Andrew> Almost. I'm fine with the theory just not the implementation. Reading:
Andrew> ! int reason = (instruction >> RSVD_INSTRUCTION_ARG_SHIFT) &
Andrew> RSVD_INSTRUCTION_ARG_MASK;
Andrew> ! if (sim_monitor (SD, CPU, cia, reason))
Andrew> ! sim_io_error (sd, "TODO sim_monitor: reason = %d, pc =
Andrew> 0x%s\n", reason, pr_addr (cia));
Andrew> just looks wierd.
Andrew> Could sim_monitor() return zero or negative to indicate fail (both are
Andrew> more common conventions) and perhaphs change ``TODO'' to something more
Andrew> meanginful :-)
Done. I've negated the sense of sim_monitor()'s result and the error
message now reads:
"sim_monitor: unhandled reason = %d, pc = 0x%s\n", reason, pr_addr (cia)
Okay to commit?
Ben
next prev parent reply other threads:[~2001-02-19 12:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-18 19:27 Ben Elliston
2001-02-19 11:12 ` Andrew Cagney
2001-02-19 12:12 ` Ben Elliston [this message]
2001-02-19 13:17 ` Andrew Cagney
2001-02-19 14:37 ` Ben Elliston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14993.32286.16403.330031@scooby.cygnus.com \
--to=bje@redhat.com \
--cc=ac131313@cygnus.com \
--cc=cgd@broadcom.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox