From: Stafford Horne <shorne@gmail.com>
To: gdb-patches@sourceware.org
Cc: openrisc@lists.librecores.org, Stafford Horne <shorne@gmail.com>
Subject: [PATCH 17/18] gdb: or1k: Updates for compiler type checking
Date: Wed, 23 Nov 2016 22:11:00 -0000 [thread overview]
Message-ID: <1479939044-1341-18-git-send-email-shorne@gmail.com> (raw)
In-Reply-To: <1479939044-1341-1-git-send-email-shorne@gmail.com>
There are several new compiler type checking enabled
in latest build/toolchain. Fix issues where void* cannot
be blindly cast to type* also issues with enum vs int.
gdb/ChangeLog:
* or1k-tdep.c (or1k_fetch_instruction): dont pass status
directly to memory_error as they are different types
(or1k_pseudo_register_read): return proper typed REG_UNKNOWN
(or1k_frame_cache): cast result to trad_frame_cache
(or1k_gdbarch_init): init gdbarch_tdep with XNEW
---
gdb/or1k-tdep.c | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/gdb/or1k-tdep.c b/gdb/or1k-tdep.c
index a0fd651..5aa0e7c 100644
--- a/gdb/or1k-tdep.c
+++ b/gdb/or1k-tdep.c
@@ -87,9 +87,7 @@
been removed. */
/*---------------------------------------------------------------------------*/
-#include "demangle.h"
#include "defs.h"
-#include <string.h>
#include "frame.h"
#include "inferior.h"
#include "symtab.h"
@@ -165,13 +163,10 @@ or1k_fetch_instruction (struct gdbarch *gdbarch,
{
enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
gdb_byte buf[OR1K_INSTLEN];
- int status;
- status = target_read_memory (addr, buf, OR1K_INSTLEN);
-
- if (status)
+ if (target_read_memory (addr, buf, OR1K_INSTLEN))
{
- memory_error (status, addr);
+ memory_error (TARGET_XFER_E_IO, addr);
}
return extract_unsigned_integer (buf, OR1K_INSTLEN, byte_order);
@@ -638,7 +633,7 @@ or1k_pseudo_register_read (struct gdbarch *gdbarch,
int regnum,
gdb_byte *buf)
{
- return 0;
+ return REG_UNKNOWN;
} /* or1k_pseudo_register_read() */
@@ -1545,7 +1540,7 @@ or1k_frame_cache (struct frame_info *this_frame,
/* Nothing to do if we already have this info */
if (NULL != *prologue_cache)
{
- return *prologue_cache;
+ return (struct trad_frame_cache *) *prologue_cache;
}
/* Get a new prologue cache and populate it with default values */
@@ -2037,7 +2032,7 @@ or1k_gdbarch_init (struct gdbarch_info info,
know which target we are talking to, but put in some defaults for now. */
binfo = info.bfd_arch_info;
- tdep = xmalloc (sizeof *tdep);
+ tdep = XNEW (struct gdbarch_tdep);
tdep->num_matchpoints = OR1K_MAX_MATCHPOINTS;
tdep->num_gpr_regs = OR1K_MAX_GPR_REGS;
tdep->bytes_per_word = binfo->bits_per_word / binfo->bits_per_byte;
--
2.7.4
next prev parent reply other threads:[~2016-11-23 22:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 22:11 [PATCH 00/18] gdb: Port for OpenRISC Stafford Horne
2016-11-23 22:11 ` [PATCH 13/18] gdb: Add OpenRISC to texinfo menu Stafford Horne
2016-11-23 22:11 ` [PATCH 04/18] gdb: add tdesc_find_register functions Stafford Horne
2016-11-23 22:11 ` Stafford Horne [this message]
2016-11-23 22:11 ` [PATCH 05/18] gdb: handle arbitrary strings in tdesc_register_in_reggroup_p Stafford Horne
2016-11-23 22:11 ` [PATCH 03/18] gdb: or1k: Add or1k_push_dummy_code and use it Stafford Horne
2016-11-23 22:11 ` [PATCH 09/18] gdb: or1k: Silence gcc warning Stafford Horne
2016-11-23 22:11 ` [PATCH 16/18] gdb: Remove corelow object from or1k linux build Stafford Horne
2016-11-23 22:11 ` [PATCH 15/18] gdb: or1k: Update calling conventions to help pass tests Stafford Horne
2016-11-23 22:13 ` [PATCH 01/18] gdb: add or1k and or1knd target support Stafford Horne
2016-11-23 22:13 ` [PATCH 12/18] gdb: or1k: Apply changes of the last two years Stafford Horne
2016-11-23 22:13 ` [PATCH 10/18] gdb: or1k: Fixes for things that broke after upstream merge Stafford Horne
2016-11-23 22:13 ` [PATCH 08/18] gdb: or1k: change or1k_push_dummy_code stack alignment Stafford Horne
2016-11-23 22:14 ` [PATCH 07/18] gdb: or1k: add target descriptor support Stafford Horne
2016-11-23 22:14 ` [PATCH 14/18] gdb: testsuite: Add or1k l.nop inscruction Stafford Horne
2016-11-23 22:14 ` [PATCH 06/18] gdb: or1k: set gdbarch num regs to gpr + spr regs Stafford Horne
2016-11-23 22:16 ` [PATCH 11/18] Add gdb for or1k build Stafford Horne
2016-11-23 22:16 ` [PATCH 02/18] gdb: or1k: Add a check for NULL ptr in or1k_skip_prologue Stafford Horne
2016-11-23 22:23 ` [PATCH 18/18] gdb: or1k: Refactor to new bp_kind_from_pc and pb_from_kind Stafford Horne
2016-11-24 20:37 ` [PATCH 00/18] gdb: Port for OpenRISC Yao Qi
2016-11-25 22:50 ` Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479939044-1341-18-git-send-email-shorne@gmail.com \
--to=shorne@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=openrisc@lists.librecores.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox