From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 847 invoked by alias); 23 Nov 2016 22:11:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 129843 invoked by uid 89); 23 Nov 2016 22:11:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=bits_per_word, 2032,7, 20327, sk:gdbarch X-HELO: mail-pf0-f195.google.com Received: from mail-pf0-f195.google.com (HELO mail-pf0-f195.google.com) (209.85.192.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 Nov 2016 22:11:23 +0000 Received: by mail-pf0-f195.google.com with SMTP id i88so1039011pfk.2 for ; Wed, 23 Nov 2016 14:11:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=v9m8aT2SbcqNzRADC4uFAHteMFo7iCRe7y5KEqf5gLc=; b=FwyV1b3LD2vXG9FmzlrGSP5a22QtGFLIfy+jo9/u1ks8z7A7+7ENqq8WbobcmvZ7sf dikddsq3MY5MhSId42FBKJUb6NGkdFuQGE//Jqg+wcnkiEBjO77XMwY/Xeb0jETwmZRE NUC1RaAKEkbev3a3BR9S6OP7OoJZJEzVgW6Jymdzh+yDOnqfbItYz2Eoizpo6/A+XKoQ lbZ5yfzXWvHf41mRwEG7u5A7d/oA5BzqWzVhxLax7rll8GgsM5Ps8iUyJ2HQwahQzB52 RhSKutuprZI3BXhIl5QreNM06zJ1EdlLQjKGZoA+KYhY+ZpL6/YlKD2xkbtD9HgPQol1 T4Zg== X-Gm-Message-State: AKaTC01mjbBT49IUTQP+KW5YBRTzNTjZQlyOiAkAmJANFwto1PiuNQHwO2B8tJ290CVm2A== X-Received: by 10.84.149.139 with SMTP id m11mr11292782pla.38.1479939081691; Wed, 23 Nov 2016 14:11:21 -0800 (PST) Received: from lianli.shorne-pla.net (z14.124-44-185.ppp.wakwak.ne.jp. [124.44.185.14]) by smtp.gmail.com with ESMTPSA id p13sm37039925pgf.47.2016.11.23.14.11.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Nov 2016 14:11:20 -0800 (PST) Received: from lianli.shorne-pla.net (localhost [127.0.0.1]) by lianli.shorne-pla.net (8.15.2/8.15.2) with ESMTPS id uANMBGYV001538 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 24 Nov 2016 07:11:16 +0900 Received: (from shorne@localhost) by lianli.shorne-pla.net (8.15.2/8.15.2/Submit) id uANMBGv7001537; Thu, 24 Nov 2016 07:11:16 +0900 From: Stafford Horne To: gdb-patches@sourceware.org Cc: openrisc@lists.librecores.org, Stafford Horne Subject: [PATCH 17/18] gdb: or1k: Updates for compiler type checking Date: Wed, 23 Nov 2016 22:11:00 -0000 Message-Id: <1479939044-1341-18-git-send-email-shorne@gmail.com> In-Reply-To: <1479939044-1341-1-git-send-email-shorne@gmail.com> References: <1479939044-1341-1-git-send-email-shorne@gmail.com> X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00696.txt.bz2 There are several new compiler type checking enabled in latest build/toolchain. Fix issues where void* cannot be blindly cast to type* also issues with enum vs int. gdb/ChangeLog: * or1k-tdep.c (or1k_fetch_instruction): dont pass status directly to memory_error as they are different types (or1k_pseudo_register_read): return proper typed REG_UNKNOWN (or1k_frame_cache): cast result to trad_frame_cache (or1k_gdbarch_init): init gdbarch_tdep with XNEW --- gdb/or1k-tdep.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/gdb/or1k-tdep.c b/gdb/or1k-tdep.c index a0fd651..5aa0e7c 100644 --- a/gdb/or1k-tdep.c +++ b/gdb/or1k-tdep.c @@ -87,9 +87,7 @@ been removed. */ /*---------------------------------------------------------------------------*/ -#include "demangle.h" #include "defs.h" -#include #include "frame.h" #include "inferior.h" #include "symtab.h" @@ -165,13 +163,10 @@ or1k_fetch_instruction (struct gdbarch *gdbarch, { enum bfd_endian byte_order = gdbarch_byte_order (gdbarch); gdb_byte buf[OR1K_INSTLEN]; - int status; - status = target_read_memory (addr, buf, OR1K_INSTLEN); - - if (status) + if (target_read_memory (addr, buf, OR1K_INSTLEN)) { - memory_error (status, addr); + memory_error (TARGET_XFER_E_IO, addr); } return extract_unsigned_integer (buf, OR1K_INSTLEN, byte_order); @@ -638,7 +633,7 @@ or1k_pseudo_register_read (struct gdbarch *gdbarch, int regnum, gdb_byte *buf) { - return 0; + return REG_UNKNOWN; } /* or1k_pseudo_register_read() */ @@ -1545,7 +1540,7 @@ or1k_frame_cache (struct frame_info *this_frame, /* Nothing to do if we already have this info */ if (NULL != *prologue_cache) { - return *prologue_cache; + return (struct trad_frame_cache *) *prologue_cache; } /* Get a new prologue cache and populate it with default values */ @@ -2037,7 +2032,7 @@ or1k_gdbarch_init (struct gdbarch_info info, know which target we are talking to, but put in some defaults for now. */ binfo = info.bfd_arch_info; - tdep = xmalloc (sizeof *tdep); + tdep = XNEW (struct gdbarch_tdep); tdep->num_matchpoints = OR1K_MAX_MATCHPOINTS; tdep->num_gpr_regs = OR1K_MAX_GPR_REGS; tdep->bytes_per_word = binfo->bits_per_word / binfo->bits_per_byte; -- 2.7.4