* [PATCH] Fix obvious gotcha in string comparison
@ 2016-10-24 21:52 Luis Machado
2016-10-24 22:25 ` Pedro Alves
0 siblings, 1 reply; 3+ messages in thread
From: Luis Machado @ 2016-10-24 21:52 UTC (permalink / raw)
To: gdb-patches
This patch fixes a gotcha when comparing exception's messages in
exception_print_same. It should've used the statically-allocated
string versions msg1 and msg2 instead.
As is, it could lead to crashes.
gdb/ChangeLog:
2016-10-24 Luis Machado <lgustavo@codesourcery.com>
* exec.c (exception_print_same): Fix string comparison to use
statically-allocated ones.
---
gdb/ChangeLog | 5 +++++
gdb/exec.c | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index be72369..388cc1f 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2016-10-24 Luis Machado <lgustavo@codesourcery.com>
+
+ * exec.c (exception_print_same): Fix string comparison to use
+ statically-allocated ones.
+
2016-10-21 Tom Tromey <tom@tromey.com>
* dwarf2expr.h (class dwarf_expr_context)
diff --git a/gdb/exec.c b/gdb/exec.c
index d858e99..67ecc63 100644
--- a/gdb/exec.c
+++ b/gdb/exec.c
@@ -152,7 +152,7 @@ exception_print_same (struct gdb_exception e1, struct gdb_exception e2)
return (e1.reason == e2.reason
&& e1.error == e2.error
- && strcmp (e1.message, e2.message) == 0);
+ && strcmp (msg1, msg2) == 0);
}
/* See gdbcore.h. */
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix obvious gotcha in string comparison
2016-10-24 21:52 [PATCH] Fix obvious gotcha in string comparison Luis Machado
@ 2016-10-24 22:25 ` Pedro Alves
2016-10-24 22:46 ` Luis Machado
0 siblings, 1 reply; 3+ messages in thread
From: Pedro Alves @ 2016-10-24 22:25 UTC (permalink / raw)
To: Luis Machado, gdb-patches
OK.
Thanks,
Pedro Alves
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix obvious gotcha in string comparison
2016-10-24 22:25 ` Pedro Alves
@ 2016-10-24 22:46 ` Luis Machado
0 siblings, 0 replies; 3+ messages in thread
From: Luis Machado @ 2016-10-24 22:46 UTC (permalink / raw)
To: Pedro Alves, gdb-patches
On 10/24/2016 05:25 PM, Pedro Alves wrote:
> OK.
>
> Thanks,
> Pedro Alves
>
Thanks, pushed as 010ece9c47f1ac08c9436b133a74472713dd709b.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-24 22:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-24 21:52 [PATCH] Fix obvious gotcha in string comparison Luis Machado
2016-10-24 22:25 ` Pedro Alves
2016-10-24 22:46 ` Luis Machado
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox