* [PATCH] Skip floating point tests in return-nodebug.exp if gdb_skip_stdio_test is true
@ 2016-09-02 8:55 Yao Qi
2016-09-02 10:26 ` Pedro Alves
0 siblings, 1 reply; 3+ messages in thread
From: Yao Qi @ 2016-09-02 8:55 UTC (permalink / raw)
To: gdb-patches
return-nodebug.exp does the test for various types, but we shouldn't
test with floating point type if gdb_skip_float_test returns true.
gdb/testsuite:
2016-09-02 Yao Qi <yao.qi@linaro.org>
* gdb.base/return-nodebug.exp: Skip the test if skip_float_test
is true and $type is "float" or "double".
---
gdb/testsuite/gdb.base/return-nodebug.exp | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/gdb/testsuite/gdb.base/return-nodebug.exp b/gdb/testsuite/gdb.base/return-nodebug.exp
index e44494f..0d58ba5 100644
--- a/gdb/testsuite/gdb.base/return-nodebug.exp
+++ b/gdb/testsuite/gdb.base/return-nodebug.exp
@@ -13,6 +13,8 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
+set skip_float_test [gdb_skip_float_test]
+
proc do_test {type} {
set typenospace [string map {{ } -} $type]
@@ -42,6 +44,9 @@ proc do_test {type} {
}
foreach type {{signed char} {short} {int} {long} {long long} {float} {double}} {
+ if { $skip_float_test && ($type == "float" || $type == "double") } {
+ continue
+ }
set typeesc [string map {{ } {\ }} $type]
set typenospace [string map {{ } -} $type]
--
1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Skip floating point tests in return-nodebug.exp if gdb_skip_stdio_test is true
2016-09-02 8:55 [PATCH] Skip floating point tests in return-nodebug.exp if gdb_skip_stdio_test is true Yao Qi
@ 2016-09-02 10:26 ` Pedro Alves
2016-09-02 14:35 ` Yao Qi
0 siblings, 1 reply; 3+ messages in thread
From: Pedro Alves @ 2016-09-02 10:26 UTC (permalink / raw)
To: Yao Qi, gdb-patches
On 09/02/2016 09:55 AM, Yao Qi wrote:
> return-nodebug.exp does the test for various types, but we shouldn't
> test with floating point type if gdb_skip_float_test returns true.
LGTM.
Thanks,
Pedro Alves
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Skip floating point tests in return-nodebug.exp if gdb_skip_stdio_test is true
2016-09-02 10:26 ` Pedro Alves
@ 2016-09-02 14:35 ` Yao Qi
0 siblings, 0 replies; 3+ messages in thread
From: Yao Qi @ 2016-09-02 14:35 UTC (permalink / raw)
To: Pedro Alves; +Cc: gdb-patches
On Fri, Sep 2, 2016 at 11:26 AM, Pedro Alves <palves@redhat.com> wrote:
>
> LGTM.
>
Thanks, patch is pushed in.
--
Yao (齐尧)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-02 14:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-02 8:55 [PATCH] Skip floating point tests in return-nodebug.exp if gdb_skip_stdio_test is true Yao Qi
2016-09-02 10:26 ` Pedro Alves
2016-09-02 14:35 ` Yao Qi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox