[PATCH] ppc: Fix record of HTM instructions

[PATCH] ppc: Fix record of HTM instructions

[Edjunior Barbosa Machado]

Hi,
the patch below fixes the record support of Hardware Transactional Memory
instructions on Power. It also solves a large number of unexpected failures
from gdb.reverse testcases sigall-precsave.exp and sigall-reverse.exp that
occur on distros which glibc uses HTM instructions. Ok?

Thanks,
--
Edjunior

gdb/ChangeLog
2016-08-17  Edjunior Barbosa Machado  <emachado@linux.vnet.ibm.com>

	* rs6000-tdep.c (ppc_process_record_op31): Handle HTM instructions.
---
 gdb/rs6000-tdep.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c
index a616cbe..eb12c5d 100644
--- a/gdb/rs6000-tdep.c
+++ b/gdb/rs6000-tdep.c
@@ -4613,17 +4613,17 @@ ppc_process_record_op31 (struct gdbarch *gdbarch, struct regcache *regcache,
 
     case 654:		/* Transaction Begin */
     case 686:		/* Transaction End */
-    case 718:		/* Transaction Check */
     case 750:		/* Transaction Suspend or Resume */
     case 782:		/* Transaction Abort Word Conditional */
     case 814:		/* Transaction Abort Doubleword Conditional */
     case 846:		/* Transaction Abort Word Conditional Immediate */
     case 878:		/* Transaction Abort Doubleword Conditional Immediate */
     case 910:		/* Transaction Abort */
-      fprintf_unfiltered (gdb_stdlog, "Cannot record Transaction instructions. "
-			  "%08x at %s, 31-%d.\n",
-			  insn, paddress (gdbarch, addr), ext);
-      return -1;
+      record_full_arch_list_add_reg (regcache, tdep->ppc_ps_regnum);
+      /* FALL-THROUGH */
+    case 718:		/* Transaction Check */
+      record_full_arch_list_add_reg (regcache, tdep->ppc_cr_regnum);
+      return 0;
 
     case 1014:		/* Data Cache Block set to Zero */
       if (target_auxv_search (&current_target, AT_DCACHEBSIZE, &at_dcsz) <= 0
-- 
2.5.5

Re: [PATCH] ppc: Fix record of HTM instructions

[Ulrich Weigand]

Edjunior Barbosa Machado wrote:

> gdb/ChangeLog
> 2016-08-17  Edjunior Barbosa Machado  <emachado@linux.vnet.ibm.com>
> 
> 	* rs6000-tdep.c (ppc_process_record_op31): Handle HTM instructions.

This is OK.

Thanks,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU/Linux compilers and toolchain
  Ulrich.Weigand@de.ibm.com

Re: [PATCH] ppc: Fix record of HTM instructions

[Edjunior Barbosa Machado]

On 08/18/2016 09:49 AM, Ulrich Weigand wrote:
> Edjunior Barbosa Machado wrote:
> 
>> gdb/ChangeLog
>> 2016-08-17  Edjunior Barbosa Machado  <emachado@linux.vnet.ibm.com>
>>
>> 	* rs6000-tdep.c (ppc_process_record_op31): Handle HTM instructions.
> 
> This is OK.
> 
> Thanks,
> Ulrich
> 

Thanks Uli for your review. Pushed the fix to main and gdb-7.12-branch:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=d44c67f38178c5ad0c083ebff6429d6e477ea42e
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=1c9c56667193b56ad5fa30ac0ae731f1d63cd6c5

--
Edjunior