From: Pedro Alves <palves@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 05/11] [C++/mingw] gdbserver casts
Date: Mon, 02 Nov 2015 19:44:00 -0000 [thread overview]
Message-ID: <1446492970-21432-6-git-send-email-palves@redhat.com> (raw)
In-Reply-To: <1446492970-21432-1-git-send-email-palves@redhat.com>
A set of obviously-needed C++ casts.
gdb/gdbserver/ChangeLog:
2015-11-01 Pedro Alves <palves@redhat.com>
* win32-i386-low.c (update_debug_registers_callback)
(win32_get_current_dr): Add cast.
* win32-low.c (thread_rec, delete_thread_info)
(continue_one_thread): Add casts.
(strwinerror): Cast FormatMessage argument to LPTSTR instead of
LPVOID.
(win32_create_inferior, suspend_one_thread): Add casts.
---
gdb/gdbserver/win32-i386-low.c | 5 +++--
gdb/gdbserver/win32-low.c | 19 ++++++++++---------
2 files changed, 13 insertions(+), 11 deletions(-)
diff --git a/gdb/gdbserver/win32-i386-low.c b/gdb/gdbserver/win32-i386-low.c
index 7c22f05..686521f 100644
--- a/gdb/gdbserver/win32-i386-low.c
+++ b/gdb/gdbserver/win32-i386-low.c
@@ -45,7 +45,7 @@ update_debug_registers_callback (struct inferior_list_entry *entry,
void *pid_p)
{
struct thread_info *thr = (struct thread_info *) entry;
- win32_thread_info *th = inferior_target_data (thr);
+ win32_thread_info *th = (win32_thread_info *) inferior_target_data (thr);
int pid = *(int *) pid_p;
/* Only update the threads of this process. */
@@ -89,7 +89,8 @@ x86_dr_low_set_control (unsigned long control)
static DWORD64
win32_get_current_dr (int dr)
{
- win32_thread_info *th = inferior_target_data (current_thread);
+ win32_thread_info *th
+ = (win32_thread_info *) inferior_target_data (current_thread);
win32_require_context (th);
diff --git a/gdb/gdbserver/win32-low.c b/gdb/gdbserver/win32-low.c
index 6e33509..2b40ca3 100644
--- a/gdb/gdbserver/win32-low.c
+++ b/gdb/gdbserver/win32-low.c
@@ -198,7 +198,7 @@ thread_rec (ptid_t ptid, int get_context)
if (thread == NULL)
return NULL;
- th = inferior_target_data (thread);
+ th = (win32_thread_info *) inferior_target_data (thread);
if (get_context)
win32_require_context (th);
return th;
@@ -229,11 +229,12 @@ child_add_thread (DWORD pid, DWORD tid, HANDLE h, void *tlb)
/* Delete a thread from the list of threads. */
static void
-delete_thread_info (struct inferior_list_entry *thread)
+delete_thread_info (struct inferior_list_entry *entry)
{
- win32_thread_info *th = inferior_target_data ((struct thread_info *) thread);
+ struct thread_info *thread = (struct thread_info *) entry;
+ win32_thread_info *th = (win32_thread_info *) inferior_target_data (thread);
- remove_thread ((struct thread_info *) thread);
+ remove_thread (thread);
CloseHandle (th->h);
free (th);
}
@@ -432,7 +433,7 @@ continue_one_thread (struct inferior_list_entry *this_thread, void *id_ptr)
{
struct thread_info *thread = (struct thread_info *) this_thread;
int thread_id = * (int *) id_ptr;
- win32_thread_info *th = inferior_target_data (thread);
+ win32_thread_info *th = (win32_thread_info *) inferior_target_data (thread);
if (thread_id == -1 || thread_id == th->tid)
{
@@ -523,7 +524,7 @@ strwinerror (DWORD error)
NULL,
error,
0, /* Default language */
- (LPVOID)&msgbuf,
+ (LPTSTR) &msgbuf,
0,
NULL);
if (chars != 0)
@@ -654,7 +655,7 @@ win32_create_inferior (char *program, char **program_args)
argslen = 1;
for (argc = 1; program_args[argc]; argc++)
argslen += strlen (program_args[argc]) + 1;
- args = alloca (argslen);
+ args = (char *) alloca (argslen);
args[0] = '\0';
for (argc = 1; program_args[argc]; argc++)
{
@@ -673,7 +674,7 @@ win32_create_inferior (char *program, char **program_args)
err = GetLastError ();
if (!ret && err == ERROR_FILE_NOT_FOUND)
{
- char *exename = alloca (strlen (program) + 5);
+ char *exename = (char *) alloca (strlen (program) + 5);
strcat (strcpy (exename, program), ".exe");
ret = create_process (exename, args, flags, &pi);
err = GetLastError ();
@@ -1344,7 +1345,7 @@ static void
suspend_one_thread (struct inferior_list_entry *entry)
{
struct thread_info *thread = (struct thread_info *) entry;
- win32_thread_info *th = inferior_target_data (thread);
+ win32_thread_info *th = (win32_thread_info *) inferior_target_data (thread);
if (!th->suspended)
{
--
1.9.3
next prev parent reply other threads:[~2015-11-02 19:44 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 19:36 [PATCH 00/11] C++/MinGW patches Pedro Alves
2015-11-02 19:36 ` [PATCH 11/11] [C++/mingw] gdbserver: gdb/host signal mixup Pedro Alves
2015-11-02 19:36 ` [PATCH 10/11] [C++/mingw] Fix windows-nat.c::xlate Pedro Alves
2015-11-02 19:36 ` [PATCH 03/11] [C++/mingw] gdb-dlfcn.c casts Pedro Alves
2015-11-02 19:36 ` [PATCH 02/11] [C++/mingw] Misc alloca casts Pedro Alves
2015-11-02 19:36 ` [PATCH 04/11] [C++/mingw] windows-nat.c casts Pedro Alves
2015-11-02 19:36 ` [PATCH 06/11] [C++/mingw] ser-tcp.c casts Pedro Alves
2015-11-02 20:40 ` Simon Marchi
2015-11-02 20:55 ` Pedro Alves
2015-11-02 21:06 ` Pedro Alves
2015-11-02 19:36 ` [PATCH 01/11] [C++/mingw] ser-mingw.c casts Pedro Alves
2015-11-02 19:43 ` [PATCH 09/11] [C++/mingw] handle_output_debug_string Pedro Alves
2015-11-02 19:44 ` Pedro Alves [this message]
2015-11-02 19:44 ` [PATCH 07/11] [C++/mingw] Define __STDC_CONSTANT_MACROS / __STDC_LIMIT_MACROS for stdint.h Pedro Alves
2015-11-02 20:47 ` Simon Marchi
2015-11-03 13:58 ` Simon Marchi
2015-11-03 14:07 ` Pedro Alves
2015-11-03 14:15 ` Simon Marchi
2015-11-03 15:13 ` Pedro Alves
2015-11-02 19:45 ` [PATCH 08/11] [C++/mingw] Simplify first chance exception handling Pedro Alves
2015-11-02 21:01 ` Simon Marchi
2015-11-02 21:09 ` Pedro Alves
2015-11-02 20:05 ` [PATCH 00/11] C++/MinGW patches Pedro Alves
2015-11-02 20:22 ` Qian Hong
2015-11-02 20:46 ` Pedro Alves
2015-11-02 21:17 ` Qian Hong
2015-11-02 23:31 ` Pedro Alves
2015-11-03 9:06 ` Qian Hong
2015-11-03 10:47 ` Qian Hong
2015-11-03 11:15 ` Qian Hong
2015-11-03 11:26 ` Pedro Alves
2015-11-03 11:41 ` Qian Hong
2015-11-03 12:11 ` Qian Hong
2015-11-03 12:34 ` Pedro Alves
2015-11-03 11:20 ` Pedro Alves
2015-11-03 16:54 ` Pedro Alves
2015-11-03 18:59 ` Qian Hong
2015-11-03 21:03 ` Qian Hong
2015-11-03 22:39 ` Pedro Alves
2015-11-09 9:53 ` Qian Hong
2015-11-17 14:50 ` Pedro Alves
2015-11-30 15:03 ` Qian Hong
2015-11-30 15:48 ` Pedro Alves
2015-11-03 12:24 ` Qian Hong
2015-11-03 12:27 ` Pedro Alves
2015-11-03 12:56 ` Qian Hong
2015-11-03 13:08 ` Pedro Alves
2015-11-03 13:23 ` Qian Hong
2015-11-03 16:52 ` Pedro Alves
2015-11-03 13:10 ` Pedro Alves
2015-11-02 21:04 ` Simon Marchi
2015-11-17 15:28 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446492970-21432-6-git-send-email-palves@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox