Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 09/11] [C++/mingw] handle_output_debug_string
Date: Mon, 02 Nov 2015 19:43:00 -0000	[thread overview]
Message-ID: <1446492970-21432-10-git-send-email-palves@redhat.com> (raw)
In-Reply-To: <1446492970-21432-1-git-send-email-palves@redhat.com>

Fixes:

 ../../../src/gdb/gdbserver/win32-low.c: In function 'int win32_kill(int)':
 ../../../src/gdb/gdbserver/win32-low.c:823:46: error: invalid conversion from 'int' to 'target_waitkind' [-fpermissive]
     struct target_waitstatus our_status = { 0 };
					       ^

handle_output_debug_string doesn't use the parameter for anything
(it's an output parameter in the gdb version), so just remove it.

gdb/gdbserver/ChangeLog:
2015-11-01  Pedro Alves  <palves@redhat.com>

	* win32-low.c (handle_output_debug_string): Remove parameter.
	(win32_kill): Remove our_status local and adjust call to
	handle_output_debug_string.
	(get_child_debug_event): Adjust call to
	handle_output_debug_string.
---
 gdb/gdbserver/win32-low.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/gdb/gdbserver/win32-low.c b/gdb/gdbserver/win32-low.c
index 2b40ca3..b1a2e56 100644
--- a/gdb/gdbserver/win32-low.c
+++ b/gdb/gdbserver/win32-low.c
@@ -747,7 +747,7 @@ win32_attach (unsigned long pid)
 
 /* Handle OUTPUT_DEBUG_STRING_EVENT from child process.  */
 static void
-handle_output_debug_string (struct target_waitstatus *ourstatus)
+handle_output_debug_string (void)
 {
 #define READ_BUFFER_LEN 1024
   CORE_ADDR addr;
@@ -819,10 +819,7 @@ win32_kill (int pid)
       if (current_event.dwDebugEventCode == EXIT_PROCESS_DEBUG_EVENT)
 	break;
       else if (current_event.dwDebugEventCode == OUTPUT_DEBUG_STRING_EVENT)
-	{
-	  struct target_waitstatus our_status = { 0 };
-	  handle_output_debug_string (&our_status);
-	}
+	handle_output_debug_string ();
     }
 
   win32_clear_inferiors ();
@@ -1572,7 +1569,7 @@ get_child_debug_event (struct target_waitstatus *ourstatus)
 		"for pid=%u tid=%x\n",
 		(unsigned) current_event.dwProcessId,
 		(unsigned) current_event.dwThreadId));
-      handle_output_debug_string (ourstatus);
+      handle_output_debug_string ();
       break;
 
     default:
-- 
1.9.3


  parent reply	other threads:[~2015-11-02 19:43 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-02 19:36 [PATCH 00/11] C++/MinGW patches Pedro Alves
2015-11-02 19:36 ` [PATCH 01/11] [C++/mingw] ser-mingw.c casts Pedro Alves
2015-11-02 19:36 ` [PATCH 06/11] [C++/mingw] ser-tcp.c casts Pedro Alves
2015-11-02 20:40   ` Simon Marchi
2015-11-02 20:55     ` Pedro Alves
2015-11-02 21:06       ` Pedro Alves
2015-11-02 19:36 ` [PATCH 04/11] [C++/mingw] windows-nat.c casts Pedro Alves
2015-11-02 19:36 ` [PATCH 02/11] [C++/mingw] Misc alloca casts Pedro Alves
2015-11-02 19:36 ` [PATCH 10/11] [C++/mingw] Fix windows-nat.c::xlate Pedro Alves
2015-11-02 19:36 ` [PATCH 03/11] [C++/mingw] gdb-dlfcn.c casts Pedro Alves
2015-11-02 19:36 ` [PATCH 11/11] [C++/mingw] gdbserver: gdb/host signal mixup Pedro Alves
2015-11-02 19:43 ` Pedro Alves [this message]
2015-11-02 19:44 ` [PATCH 07/11] [C++/mingw] Define __STDC_CONSTANT_MACROS / __STDC_LIMIT_MACROS for stdint.h Pedro Alves
2015-11-02 20:47   ` Simon Marchi
2015-11-03 13:58     ` Simon Marchi
2015-11-03 14:07       ` Pedro Alves
2015-11-03 14:15         ` Simon Marchi
2015-11-03 15:13           ` Pedro Alves
2015-11-02 19:44 ` [PATCH 05/11] [C++/mingw] gdbserver casts Pedro Alves
2015-11-02 19:45 ` [PATCH 08/11] [C++/mingw] Simplify first chance exception handling Pedro Alves
2015-11-02 21:01   ` Simon Marchi
2015-11-02 21:09     ` Pedro Alves
2015-11-02 20:05 ` [PATCH 00/11] C++/MinGW patches Pedro Alves
2015-11-02 20:22   ` Qian Hong
2015-11-02 20:46     ` Pedro Alves
2015-11-02 21:17       ` Qian Hong
2015-11-02 23:31         ` Pedro Alves
2015-11-03  9:06           ` Qian Hong
2015-11-03 10:47       ` Qian Hong
2015-11-03 11:15         ` Qian Hong
2015-11-03 11:26           ` Pedro Alves
2015-11-03 11:41             ` Qian Hong
2015-11-03 12:11               ` Qian Hong
2015-11-03 12:34               ` Pedro Alves
2015-11-03 11:20         ` Pedro Alves
2015-11-03 16:54           ` Pedro Alves
2015-11-03 18:59             ` Qian Hong
2015-11-03 21:03             ` Qian Hong
2015-11-03 22:39               ` Pedro Alves
2015-11-09  9:53                 ` Qian Hong
2015-11-17 14:50                   ` Pedro Alves
2015-11-30 15:03                     ` Qian Hong
2015-11-30 15:48                       ` Pedro Alves
2015-11-03 12:24     ` Qian Hong
2015-11-03 12:27       ` Pedro Alves
2015-11-03 12:56         ` Qian Hong
2015-11-03 13:08           ` Pedro Alves
2015-11-03 13:23             ` Qian Hong
2015-11-03 16:52               ` Pedro Alves
2015-11-03 13:10           ` Pedro Alves
2015-11-02 21:04 ` Simon Marchi
2015-11-17 15:28   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1446492970-21432-10-git-send-email-palves@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox