From: Yao Qi <qiyaoltc@gmail.com>
To: marcus.shawcroft@gmail.com
Cc: gdb-patches@sourceware.org, binutils@sourceware.org
Subject: [PATCH 2/3] [aarch64] expose disas_aarch64_insn and rename it to aarch64_decode_insn
Date: Fri, 02 Oct 2015 11:24:00 -0000 [thread overview]
Message-ID: <1443785039-24602-3-git-send-email-yao.qi@linaro.org> (raw)
In-Reply-To: <1443785039-24602-1-git-send-email-yao.qi@linaro.org>
We want to use disas_aarch64_insn inside GDB to decode instructions, so
this patch exposes it and rename it to aarch64_decode_insn to follow
the conventions of other interfaces. This patch also change argument
insn type from uint32_t to aarch64_insn.
include/opcode:
2015-10-02 Yao Qi <yao.qi@linaro.org>
* aarch64.h (aarch64_decode_insn): Declare it.
opcodes:
2015-10-02 Yao Qi <yao.qi@linaro.org>
* aarch64-dis.c (disas_aarch64_insn): Remove static. Change
argument insn type to aarch64_insn. Rename to ...
(aarch64_decode_insn): ... it.
(print_insn_aarch64_word): Caller updated.
---
include/opcode/aarch64.h | 3 +++
opcodes/aarch64-dis.c | 9 +++++----
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/include/opcode/aarch64.h b/include/opcode/aarch64.h
index dcf0fef..d0c7489 100644
--- a/include/opcode/aarch64.h
+++ b/include/opcode/aarch64.h
@@ -925,6 +925,9 @@ aarch64_stack_pointer_p (const aarch64_opnd_info *);
extern
int aarch64_zero_register_p (const aarch64_opnd_info *);
+extern
+int aarch64_decode_insn (aarch64_insn, aarch64_inst *);
+
/* Given an operand qualifier, return the expected data element size
of a qualified operand. */
extern unsigned char
diff --git a/opcodes/aarch64-dis.c b/opcodes/aarch64-dis.c
index e0faeb5..fe3caac 100644
--- a/opcodes/aarch64-dis.c
+++ b/opcodes/aarch64-dis.c
@@ -2029,10 +2029,11 @@ user_friendly_fixup (aarch64_inst *inst)
}
}
-/* Decode INSN and fill in *INST the instruction information. */
+/* Decode INSN and fill in *INST the instruction information. Return zero
+ on success. */
-static int
-disas_aarch64_insn (uint32_t insn, aarch64_inst *inst)
+int
+aarch64_decode_insn (aarch64_insn insn, aarch64_inst *inst)
{
const aarch64_opcode *opcode = aarch64_opcode_lookup (insn);
@@ -2171,7 +2172,7 @@ print_insn_aarch64_word (bfd_vma pc,
addresses, since the addend is not currently pc-relative. */
pc = 0;
- ret = disas_aarch64_insn (word, &inst);
+ ret = aarch64_decode_insn (word, &inst);
if (((word >> 21) & 0x3ff) == 1)
{
--
1.9.1
next prev parent reply other threads:[~2015-10-02 11:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 16:35 [PATCH 0/2] [aarch64] Use opcodes to decode instructions in GDB Yao Qi
2015-10-01 16:35 ` [PATCH 1/2] [aarch64] Remove argument pc from disas_aarch64_insn Yao Qi
2015-10-01 16:36 ` [PATCH 2/2] [aarch64] Use opcodes to decode instructions in GDB Yao Qi
2015-10-02 7:51 ` Marcus Shawcroft
2015-10-02 11:24 ` [PATCH 0/3 V2] " Yao Qi
2015-10-02 11:24 ` [PATCH 3/3] [aarch64] use aarch64_decode_insn " Yao Qi
2015-10-07 8:56 ` Yao Qi
2015-10-02 11:24 ` Yao Qi [this message]
2015-10-02 12:35 ` [PATCH 2/3] [aarch64] expose disas_aarch64_insn and rename it to aarch64_decode_insn Marcus Shawcroft
2015-10-02 14:32 ` Yao Qi
2015-10-02 11:24 ` [PATCH 1/3] [aarch64] Remove argument pc from disas_aarch64_insn Yao Qi
2015-10-02 12:30 ` Marcus Shawcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443785039-24602-3-git-send-email-yao.qi@linaro.org \
--to=qiyaoltc@gmail.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=marcus.shawcroft@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox