From: Yao Qi <qiyaoltc@gmail.com>
To: gdb-patches@sourceware.org, binutils@sourceware.org
Subject: [PATCH 1/2] [aarch64] Remove argument pc from disas_aarch64_insn
Date: Thu, 01 Oct 2015 16:35:00 -0000 [thread overview]
Message-ID: <1443717344-8632-2-git-send-email-yao.qi@linaro.org> (raw)
In-Reply-To: <1443717344-8632-1-git-send-email-yao.qi@linaro.org>
I happen to see that argument pc is not used inside disas_aarch64_insn
at all. This patch is to remove it.
OK to apply?
opcodes:
2015-10-01 Yao Qi <yao.qi@linaro.org>
* aarch64-dis.c (disas_aarch64_insn): Remove argument PC.
(print_insn_aarch64_word): Caller updated.
---
opcodes/aarch64-dis.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/opcodes/aarch64-dis.c b/opcodes/aarch64-dis.c
index 5fec4ee..e0faeb5 100644
--- a/opcodes/aarch64-dis.c
+++ b/opcodes/aarch64-dis.c
@@ -2032,8 +2032,7 @@ user_friendly_fixup (aarch64_inst *inst)
/* Decode INSN and fill in *INST the instruction information. */
static int
-disas_aarch64_insn (uint64_t pc ATTRIBUTE_UNUSED, uint32_t insn,
- aarch64_inst *inst)
+disas_aarch64_insn (uint32_t insn, aarch64_inst *inst)
{
const aarch64_opcode *opcode = aarch64_opcode_lookup (insn);
@@ -2172,7 +2171,7 @@ print_insn_aarch64_word (bfd_vma pc,
addresses, since the addend is not currently pc-relative. */
pc = 0;
- ret = disas_aarch64_insn (pc, word, &inst);
+ ret = disas_aarch64_insn (word, &inst);
if (((word >> 21) & 0x3ff) == 1)
{
--
1.9.1
next prev parent reply other threads:[~2015-10-01 16:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 16:35 [PATCH 0/2] [aarch64] Use opcodes to decode instructions in GDB Yao Qi
2015-10-01 16:35 ` Yao Qi [this message]
2015-10-01 16:36 ` [PATCH 2/2] " Yao Qi
2015-10-02 7:51 ` Marcus Shawcroft
2015-10-02 11:24 ` [PATCH 0/3 V2] " Yao Qi
2015-10-02 11:24 ` [PATCH 1/3] [aarch64] Remove argument pc from disas_aarch64_insn Yao Qi
2015-10-02 12:30 ` Marcus Shawcroft
2015-10-02 11:24 ` [PATCH 2/3] [aarch64] expose disas_aarch64_insn and rename it to aarch64_decode_insn Yao Qi
2015-10-02 12:35 ` Marcus Shawcroft
2015-10-02 14:32 ` Yao Qi
2015-10-02 11:24 ` [PATCH 3/3] [aarch64] use aarch64_decode_insn to decode instructions in GDB Yao Qi
2015-10-07 8:56 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443717344-8632-2-git-send-email-yao.qi@linaro.org \
--to=qiyaoltc@gmail.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox