From: Jon Turney <jon.turney@dronecode.org.uk>
To: gdb-patches@sourceware.org
Cc: Jon Turney <jon.turney@dronecode.org.uk>
Subject: [PATCH 5/5] windows-nat: Don't change current_event.dwThreadId in handle_output_debug_string()
Date: Thu, 16 Apr 2015 19:24:00 -0000 [thread overview]
Message-ID: <1429212209-20548-6-git-send-email-jon.turney@dronecode.org.uk> (raw)
In-Reply-To: <1429212209-20548-1-git-send-email-jon.turney@dronecode.org.uk>
Since a Cygwin signal may be reported by a different thread to the thread the
signal is to be delivered to, use the signal target thread id by returning it,
rather than re-writing the thread id in current_event.
Altering current_event.dwThreadId() will cause ContinueDebugEvent() to be
applied to the wrong thread and fail, leaving the actual thread which reported
the debug event stuck in the suspended state.
gdb/ChangeLog:
2015-04-16 Jon Turney <jon.turney@dronecode.org.uk>
* windows-nat.c (handle_output_debug_string): Don't change
current_event.dwThreadId.
(get_windows_debug_event): Use thread_id, rather than relying on
current_event.dwThreadId being changed.
---
gdb/ChangeLog | 7 +++++++
gdb/windows-nat.c | 3 +--
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c
index 94d295e..9a4276e 100644
--- a/gdb/windows-nat.c
+++ b/gdb/windows-nat.c
@@ -850,7 +850,6 @@ handle_output_debug_string (struct target_waitstatus *ourstatus)
__COPY_CONTEXT_SIZE, &n)
&& n == __COPY_CONTEXT_SIZE)
have_saved_context = 1;
- current_event.dwThreadId = retval;
}
}
#endif
@@ -1508,7 +1507,7 @@ get_windows_debug_event (struct target_ops *ops,
thread_id);
current_thread = th;
if (!current_thread)
- current_thread = thread_rec (current_event.dwThreadId, TRUE);
+ current_thread = thread_rec (thread_id, TRUE);
}
out:
--
2.1.4
next prev parent reply other threads:[~2015-04-16 19:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-14 11:03 [PATCH] Fixes to Cygwin-specific signal handling Jon Turney
2015-04-14 13:16 ` Joel Brobecker
2015-04-14 14:38 ` Eli Zaretskii
2015-04-16 19:24 ` Jon TURNEY
2015-04-22 14:23 ` Joel Brobecker
2015-04-16 19:23 ` [PATCH 0/5] Fix to Cygwin-specific signal handling (v2) Jon Turney
2015-04-16 19:23 ` [PATCH 2/5] windows-nat: Cleanups in get_windows_debug_event Jon Turney
2015-04-22 13:52 ` Joel Brobecker
2015-04-16 19:24 ` [PATCH 4/5] windows-nat: Report an error if ContinueDebugEvent() fails Jon Turney
2015-04-22 14:10 ` Joel Brobecker
2015-04-16 19:24 ` [PATCH 3/5] windows-nat: Fix misspelling in debug output Jon Turney
2015-04-22 13:55 ` Joel Brobecker
2015-04-16 19:24 ` [PATCH 1/5] windows-nat: Don't use ternary conditional operator in get_windows_debug_event Jon Turney
2015-04-22 13:50 ` Joel Brobecker
2015-04-16 19:24 ` Jon Turney [this message]
2015-04-22 14:18 ` [PATCH 5/5] windows-nat: Don't change current_event.dwThreadId in handle_output_debug_string() Joel Brobecker
2015-06-10 13:06 ` [PATCH 0/5] Fix to Cygwin-specific signal handling (v2) Jon TURNEY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429212209-20548-6-git-send-email-jon.turney@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox