From: Jiri Gaisler <jiri@gaisler.se>
To: gdb-patches@sourceware.org
Cc: Jiri Gaisler <jiri@gaisler.se>
Subject: [PATCH v4 02/13] sim/erc32: Removed type mismatch compiler warnings
Date: Tue, 17 Mar 2015 21:03:00 -0000 [thread overview]
Message-ID: <1426626170-21401-3-git-send-email-jiri@gaisler.se> (raw)
In-Reply-To: <1426626170-21401-1-git-send-email-jiri@gaisler.se>
* func.c (exec_cmd) : silence compiler warnings when calling system().
(batch) : replace fgets() with getline().
---
sim/erc32/func.c | 24 +++++++++++++++---------
1 file changed, 15 insertions(+), 9 deletions(-)
diff --git a/sim/erc32/func.c b/sim/erc32/func.c
index 260ceff..e42b0ec 100644
--- a/sim/erc32/func.c
+++ b/sim/erc32/func.c
@@ -80,20 +80,24 @@ batch(sregs, fname)
char *fname;
{
FILE *fp;
- char lbuf[1024];
+ char *lbuf = NULL;
+ size_t len = 0;
+ ssize_t tmp;
+ size_t slen;
if ((fp = fopen(fname, "r")) == NULL) {
fprintf(stderr, "couldn't open batch file %s\n", fname);
return (0);
}
- while (!feof(fp)) {
- lbuf[0] = 0;
- fgets(lbuf, 1023, fp);
- if ((strlen(lbuf) > 0) && (lbuf[strlen(lbuf) - 1] == '\n'))
- lbuf[strlen(lbuf) - 1] = 0;
- printf("sis> %s\n", lbuf);
- exec_cmd(sregs, lbuf);
+ while (getline(&lbuf, &len, fp) > -1) {
+ slen = strlen(lbuf);
+ if (slen && (lbuf[slen - 1] == '\n')) {
+ lbuf[slen - 1] = 0;
+ printf("sis> %s\n", lbuf);
+ exec_cmd(sregs, lbuf);
+ }
}
+ free(lbuf);
fclose(fp);
return (1);
}
@@ -554,7 +558,9 @@ exec_cmd(sregs, cmd)
sim_halt();
} else if (strncmp(cmd1, "shell", clen) == 0) {
if ((cmd1 = strtok(NULL, " \t\n\r")) != NULL) {
- system(&cmdsave[clen]);
+ if (system(&cmdsave[clen])) {
+ /* Silence unused return value warning. */
+ }
}
} else if (strncmp(cmd1, "step", clen) == 0) {
stat = run_sim(sregs, 1, 1);
--
1.9.1
next prev parent reply other threads:[~2015-03-17 21:03 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 21:03 [PATCH v4 00/13] Update of the SPARC SIS simulator Jiri Gaisler
2015-03-17 21:03 ` [PATCH v4 11/13] sim/erc32: Updated documentation Jiri Gaisler
2015-03-28 7:17 ` Mike Frysinger
2015-03-17 21:03 ` [PATCH v4 10/13] sim/erc32: Add support for LEON2 processor emulation Jiri Gaisler
2015-03-28 7:21 ` Mike Frysinger
2015-03-17 21:03 ` Jiri Gaisler [this message]
2015-03-17 22:59 ` [PATCH v4 02/13] sim/erc32: Removed type mismatch compiler warnings Mike Frysinger
2015-03-17 21:03 ` [PATCH v4 07/13] sim/erc32: Access memory subsystem through struct memsys Jiri Gaisler
2015-03-28 7:15 ` Mike Frysinger
2015-03-17 21:03 ` [PATCH v4 01/13] sim/erc32: Added -v command line switch for verbose output Jiri Gaisler
2015-03-17 22:56 ` Mike Frysinger
2015-03-17 21:03 ` [PATCH v4 06/13] sim/erc32: Use gdb callback for UART I/O when linked with gdb Jiri Gaisler
2015-03-28 7:13 ` Mike Frysinger
2015-03-17 21:03 ` [PATCH v4 12/13] sim/erc32: Add data watchpoint support Jiri Gaisler
2015-03-28 7:16 ` Mike Frysinger
2015-03-17 21:03 ` [PATCH v4 04/13] sim/erc32: Use memory_iread() function for instruction fetching Jiri Gaisler
2015-03-28 7:01 ` Mike Frysinger
2015-03-17 21:03 ` [PATCH v4 03/13] sim/erc32: Switched emulated memory to host endian order Jiri Gaisler
2015-03-22 22:46 ` Mike Frysinger
2015-03-23 9:01 ` Jiri Gaisler
2015-03-28 7:41 ` Mike Frysinger
2015-03-28 8:21 ` Jiri Gaisler
2015-03-24 9:39 ` Jiri Gaisler
2015-03-27 10:26 ` Jiri Gaisler
2015-03-17 21:03 ` [PATCH v4 05/13] sim/erc32: Fix a few compiler warnings Jiri Gaisler
2015-03-28 7:06 ` Mike Frysinger
2015-03-17 21:03 ` [PATCH v4 09/13] sim/erc32: Add support for LEON3 processor emulation Jiri Gaisler
2015-03-17 21:04 ` [PATCH v4 08/13] sim/erc32: Move local extern declarations into sis.h Jiri Gaisler
2015-03-17 21:04 ` [PATCH v4 13/13] Add watchpoint support to gdb simulator interface Jiri Gaisler
2015-03-28 7:19 ` Mike Frysinger
2015-03-30 20:51 ` Jiri Gaisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426626170-21401-3-git-send-email-jiri@gaisler.se \
--to=jiri@gaisler.se \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox