[pushed] Rename windows-termcap.c -> stub-termcap.c

[pushed] Rename windows-termcap.c -> stub-termcap.c

[Pedro Alves]

Preparation for using this on all hosts.

Confirmed that --host=x86_64-w64-mingw32 still builds the stub
termcap.

gdb/ChangeLog:
2015-02-26  Pedro Alves  <palves@redhat.com>

	* windows-termcap.c: Rename to ...
	* stub-termcap.c: ... this.  Adjust header line.
	* Makefile.in (SFILES): Refer to stub-termcap.c instead of
	windows-termcap.c.
	* configure: Regenerate.
	* configure.ac: Refer to stub-termcap.o instead of
	windows-termcap.o.
	* gdb_curses.h: Mention stub-termcap.c instead of
	windows-termcap.c.
---
 gdb/ChangeLog                             | 12 ++++++++++++
 gdb/Makefile.in                           |  2 +-
 gdb/configure                             |  2 +-
 gdb/configure.ac                          |  2 +-
 gdb/gdb_curses.h                          |  2 +-
 gdb/{windows-termcap.c => stub-termcap.c} |  2 +-
 6 files changed, 17 insertions(+), 5 deletions(-)
 rename gdb/{windows-termcap.c => stub-termcap.c} (96%)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 3b21d8c..1804b21 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,15 @@
+2015-02-26  Pedro Alves  <palves@redhat.com>
+
+	* windows-termcap.c: Rename to ...
+	* stub-termcap.c: ... this.  Adjust header line.
+	* Makefile.in (SFILES): Refer to stub-termcap.c instead of
+	windows-termcap.c.
+	* configure: Regenerate.
+	* configure.ac: Refer to stub-termcap.o instead of
+	windows-termcap.o.
+	* gdb_curses.h: Mention stub-termcap.c instead of
+	windows-termcap.c.
+
 2015-02-26  Jan Kratochvil  <jan.kratochvil@redhat.com>
 
 	* compile/compile-c-symbols.c (convert_one_symbol, convert_symbol_bmsym)
diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index 16e2f1c..e9f22d6 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -868,7 +868,7 @@ SFILES = ada-exp.y ada-lang.c ada-typeprint.c ada-valprint.c ada-tasks.c \
 	jit.c \
 	xml-syscall.c \
 	annotate.c common/signals.c copying.c dfp.c gdb.c inf-child.c \
-	sol-thread.c windows-termcap.c \
+	sol-thread.c stub-termcap.c \
 	common/gdb_vecs.c common/common-utils.c common/xml-utils.c \
 	common/ptid.c common/buffer.c gdb-dlfcn.c common/agent.c \
 	common/format.c common/filestuff.c btrace.c record-btrace.c ctf.c \
diff --git a/gdb/configure b/gdb/configure
index bb9697d..88fbaab 100755
--- a/gdb/configure
+++ b/gdb/configure
@@ -7190,7 +7190,7 @@ case $host_os in
   *mingw32*)
     if test x"$curses_found" != xyes; then
       ac_cv_search_tgetent="none required"
-      CONFIG_OBS="$CONFIG_OBS windows-termcap.o"
+      CONFIG_OBS="$CONFIG_OBS stub-termcap.o"
     fi ;;
 esac
 
diff --git a/gdb/configure.ac b/gdb/configure.ac
index 90bf71c..6ac8adb 100644
--- a/gdb/configure.ac
+++ b/gdb/configure.ac
@@ -613,7 +613,7 @@ case $host_os in
   *mingw32*)
     if test x"$curses_found" != xyes; then
       ac_cv_search_tgetent="none required"
-      CONFIG_OBS="$CONFIG_OBS windows-termcap.o"
+      CONFIG_OBS="$CONFIG_OBS stub-termcap.o"
     fi ;;
 esac
 
diff --git a/gdb/gdb_curses.h b/gdb/gdb_curses.h
index f575a01..9b3707a 100644
--- a/gdb/gdb_curses.h
+++ b/gdb/gdb_curses.h
@@ -48,7 +48,7 @@
 #include <term.h>
 #else
 /* On MinGW, a real termcap library is usually not present.  Stub versions
-   of the termcap functions will be built from windows-termcap.c.  Readline
+   of the termcap functions will be built from stub-termcap.c.  Readline
    provides its own extern declarations when there's no termcap.h; do the
    same here for the termcap functions used in GDB.  */
 extern int tgetnum (const char *);
diff --git a/gdb/windows-termcap.c b/gdb/stub-termcap.c
similarity index 96%
rename from gdb/windows-termcap.c
rename to gdb/stub-termcap.c
index caafc47..cc8632c 100644
--- a/gdb/windows-termcap.c
+++ b/gdb/stub-termcap.c
@@ -1,4 +1,4 @@
-/* Win32 termcap emulation.
+/* A very minimal do-nothing termcap emulation stub.
 
    Copyright (C) 2005-2015 Free Software Foundation, Inc.
 
-- 
1.9.3

Re: [pushed] Rename windows-termcap.c -> stub-termcap.c

[Eli Zaretskii]

> From: Pedro Alves <palves@redhat.com>
> Date: Thu, 26 Feb 2015 17:20:58 +0000
> 
> Preparation for using this on all hosts.
> 
> Confirmed that --host=x86_64-w64-mingw32 still builds the stub
> termcap.

I think we should verify that a non-MinGW host which lacks termcap
will still work with the stub.  Readline has a few MinGW-specific
fragments, at least one of them seems to be related to termcap; if
some other host doesn't use similar workarounds in Readline, it might
be subtly broken.

Thanks.

Re: [pushed] Rename windows-termcap.c -> stub-termcap.c

[Pedro Alves]

On 02/26/2015 05:36 PM, Eli Zaretskii wrote:
>> From: Pedro Alves <palves@redhat.com>
>> Date: Thu, 26 Feb 2015 17:20:58 +0000
>>
>> Preparation for using this on all hosts.
>>
>> Confirmed that --host=x86_64-w64-mingw32 still builds the stub
>> termcap.
> 
> I think we should verify that a non-MinGW host which lacks termcap
> will still work with the stub.  

Agreed, I tried that locally (and so did Bernd), but note this patch
does just the rename, doesn't make GDB use the fallback stub on
all hosts yet.

> Readline has a few MinGW-specific
> fragments, at least one of them seems to be related to termcap; if
> some other host doesn't use similar workarounds in Readline, it might
> be subtly broken.

Thanks,
Pedro Alves

Re: [pushed] Rename windows-termcap.c -> stub-termcap.c

[Mark Kettenis]

> From: Pedro Alves <palves@redhat.com>
> Date: Thu, 26 Feb 2015 17:20:58 +0000
> 
> Preparation for using this on all hosts.

Why?

Re: [pushed] Rename windows-termcap.c -> stub-termcap.c

[Pedro Alves]

On 02/26/2015 05:40 PM, Mark Kettenis wrote:
>> From: Pedro Alves <palves@redhat.com>
>> Date: Thu, 26 Feb 2015 17:20:58 +0000
>>
>> Preparation for using this on all hosts.
> 
> Why?
> 

https://sourceware.org/ml/gdb-patches/2015-02/msg00668.html
https://sourceware.org/ml/binutils/2015-02/msg00294.html

Thanks,
Pedro Alves