From: Steve Ellcey <sellcey@imgtec.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: "Jose E. Marchesi" <jose.marchesi@oracle.com>,
Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: Build failure with probe patch
Date: Thu, 19 Feb 2015 21:59:00 -0000 [thread overview]
Message-ID: <1424383182.27855.133.camel@ubuntu-sellcey> (raw)
In-Reply-To: <87bnkpin70.fsf@redhat.com>
On Thu, 2015-02-19 at 16:52 -0500, Sergio Durigan Junior wrote:
> > 2015-02-19 Steve Ellcey <sellcey@imgtec.com>
> >
> > * dtrace-probe.c (dtrace_process_dof_probe): Initialize arg.expr.
> > (dtrace_get_probes) Change dof type.
>
> I prefer "Change type of variable 'dof'".
Ok.
> > - dtrace_process_dof (sect, objfile, probesp, dof);
> > + dtrace_process_dof (sect, objfile, probesp, (struct dtrace_dof_hdr *) dof);
>
> This line is too long. Break it after "probesp,".
OK, I will break that line up (should have seen that myself).
Steve Ellcey
sellcey@imgtec
next prev parent reply other threads:[~2015-02-19 21:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 17:51 Steve Ellcey
2015-02-18 23:58 ` Sergio Durigan Junior
2015-02-19 0:48 ` Steve Ellcey
2015-02-19 4:39 ` Sergio Durigan Junior
2015-02-19 15:55 ` Jose E. Marchesi
2015-02-19 16:53 ` Pedro Alves
2015-02-19 17:32 ` Jose E. Marchesi
2015-02-19 17:48 ` Steve Ellcey
2015-02-19 20:41 ` Jose E. Marchesi
2015-02-19 21:18 ` Sergio Durigan Junior
2015-02-19 21:48 ` Steve Ellcey
2015-02-19 21:52 ` Sergio Durigan Junior
2015-02-19 21:59 ` Steve Ellcey [this message]
2015-02-19 18:30 ` Pedro Alves
2015-02-19 20:11 ` Jose E. Marchesi
2015-02-19 10:43 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424383182.27855.133.camel@ubuntu-sellcey \
--to=sellcey@imgtec.com \
--cc=gdb-patches@sourceware.org \
--cc=jose.marchesi@oracle.com \
--cc=palves@redhat.com \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox