From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12959 invoked by alias); 19 Feb 2015 21:59:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12946 invoked by uid 89); 19 Feb 2015 21:59:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mailapp01.imgtec.com Received: from mailapp01.imgtec.com (HELO mailapp01.imgtec.com) (195.59.15.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Feb 2015 21:59:47 +0000 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id 1399432765FF4; Thu, 19 Feb 2015 21:59:41 +0000 (GMT) Received: from BAMAIL02.ba.imgtec.org (10.20.40.28) by KLMAIL01.kl.imgtec.org (192.168.5.35) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 19 Feb 2015 21:59:44 +0000 Received: from [10.20.3.58] (10.20.3.58) by bamail02.ba.imgtec.org (10.20.40.28) with Microsoft SMTP Server (TLS) id 14.3.174.1; Thu, 19 Feb 2015 13:59:42 -0800 Message-ID: <1424383182.27855.133.camel@ubuntu-sellcey> Subject: Re: Build failure with probe patch From: Steve Ellcey Reply-To: To: Sergio Durigan Junior CC: "Jose E. Marchesi" , Pedro Alves , Date: Thu, 19 Feb 2015 21:59:00 -0000 In-Reply-To: <87bnkpin70.fsf@redhat.com> References: <87wq3ercw0.fsf@redhat.com> <1424306916.27855.115.camel@ubuntu-sellcey> <87r3tl7uwz.fsf@oracle.com> <54E6150B.9060808@redhat.com> <87vbix3iqm.fsf@oracle.com> <1424368119.27855.123.camel@ubuntu-sellcey> <87egply6gs.fsf@oracle.com> <87h9uhk4go.fsf@redhat.com> <1424382499.27855.130.camel@ubuntu-sellcey> <87bnkpin70.fsf@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-SW-Source: 2015-02/txt/msg00559.txt.bz2 On Thu, 2015-02-19 at 16:52 -0500, Sergio Durigan Junior wrote: > > 2015-02-19 Steve Ellcey > > > > * dtrace-probe.c (dtrace_process_dof_probe): Initialize arg.expr. > > (dtrace_get_probes) Change dof type. > > I prefer "Change type of variable 'dof'". Ok. > > - dtrace_process_dof (sect, objfile, probesp, dof); > > + dtrace_process_dof (sect, objfile, probesp, (struct dtrace_dof_hdr *) dof); > > This line is too long. Break it after "probesp,". OK, I will break that line up (should have seen that myself). Steve Ellcey sellcey@imgtec