Re: [PATCH v2] Add type for $_tlb->process_environment_block->process_parameters

["Hannes Domani via gdb-patches" <gdb-patches@sourceware.org>]

 Am Donnerstag, 16. Januar 2020, 20:56:45 MEZ hat Simon Marchi <simark@simark.ca> Folgendes geschrieben:

> > @@ -219,6 +227,58 @@ windows_get_tlb_type (struct gdbarch *gdbarch)
> >                  NULL);
> >    TYPE_TARGET_TYPE (peb_ldr_ptr_type) = peb_ldr_type;
> >
> > +  /* struct UNICODE_STRING */
> > +  uni_str_type = arch_composite_type (gdbarch, xstrdup ("unicode_string"),
> > +                      TYPE_CODE_STRUCT);
> > +
> > +  append_composite_type_field (uni_str_type, "length", word_type);
> > +  append_composite_type_field (uni_str_type, "maximum_length", word_type);
> > +  append_composite_type_field_aligned (uni_str_type, "buffer",
> > +                      wchar_ptr_type,
> > +                      TYPE_LENGTH (wchar_ptr_type));
> > +
> > +  /* struct _RTL_USER_PROCESS_PARAMETERS */
> > +  rupp_type = arch_composite_type (gdbarch,
> > +                  xstrdup ("rtl_user_process_parameters"),
> > +                  TYPE_CODE_STRUCT);
>
>
> I'm pretty sure it would be fine to not xstrdup the names.  gdbarch types are never
> freed (we don't delete gdbarch objects), and even then they don't assume that their
> name has been dynamically allocated, they would not try to free it.

Pushed with this change, thanks.


Hannes