From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59438 invoked by alias); 16 Jan 2020 20:19:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 59421 invoked by uid 89); 16 Jan 2020 20:19:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=H*x:5.0, H*x:Windows X-HELO: sonic302-21.consmr.mail.ir2.yahoo.com Received: from sonic302-21.consmr.mail.ir2.yahoo.com (HELO sonic302-21.consmr.mail.ir2.yahoo.com) (87.248.110.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 Jan 2020 20:19:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1579205939; bh=sTazbmeNJLO0vPZyZeRUbXpSBBojJe5IuOsu/24oZfw=; h=Date:From:To:In-Reply-To:References:Subject:From:Subject; b=FfIajo5jnRM479qFfGXKCWK/s7cs0UKBL2d64/mM0z+Oe9B8/y1j4tbQagACCgwj3EyWMltLbC7HMBA+tyFacJmh9QesFGPgwrcj6EZsHZ9yWIFIeMsIk1+PKyac3tMUzKa7sCGhV6yoEd2Bhrv52RdM/Ltz/R2XS7+MFnt5BqJcW4J+ugcuxdYiUsKhsC47j/mhnj79h9oxvW7UglJgaSgFuWgpwdLE8HnIa3DfCcxEJqRS6IOs7k+eLpqQriGkMS5UBNbX8mKVLBvyGMvs1V7qTDeJfi/EBbj7IF1z/j6Zzpectl/GnOBk8++KkUQ8GtsBb1Rt9D1YC8tqKHLxxw== Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.ir2.yahoo.com with HTTP; Thu, 16 Jan 2020 20:18:59 +0000 Date: Thu, 16 Jan 2020 20:23:00 -0000 From: "Hannes Domani via gdb-patches" Reply-To: Hannes Domani To: Gdb-patches Message-ID: <141361473.21346688.1579205935219@mail.yahoo.com> In-Reply-To: References: <20200116180050.15777-1-ssbssa.ref@yahoo.de> <20200116180050.15777-1-ssbssa@yahoo.de> Subject: Re: [PATCH v2] Add type for $_tlb->process_environment_block->process_parameters MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00465.txt.bz2 Am Donnerstag, 16. Januar 2020, 20:56:45 MEZ hat Simon Marchi Folgendes geschrieben: > > @@ -219,6 +227,58 @@ windows_get_tlb_type (struct gdbarch *gdbarch) > >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 NULL); > >=C2=A0=C2=A0=C2=A0 TYPE_TARGET_TYPE (peb_ldr_ptr_type) =3D peb_ldr_type; > > > > +=C2=A0 /* struct UNICODE_STRING */ > > +=C2=A0 uni_str_type =3D arch_composite_type (gdbarch, xstrdup ("unicod= e_string"), > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 TYPE_CODE_STRUCT); > > + > > +=C2=A0 append_composite_type_field (uni_str_type, "length", word_type); > > +=C2=A0 append_composite_type_field (uni_str_type, "maximum_length", wo= rd_type); > > +=C2=A0 append_composite_type_field_aligned (uni_str_type, "buffer", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 wchar_ptr_type, > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 TYPE_LENGTH (wcha= r_ptr_type)); > > + > > +=C2=A0 /* struct _RTL_USER_PROCESS_PARAMETERS */ > > +=C2=A0 rupp_type =3D arch_composite_type (gdbarch, > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 xstrdup ("rtl_user_process_parameters"), > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 TYPE_CODE_STRUCT); > > > I'm pretty sure it would be fine to not xstrdup the names.=C2=A0 gdbarch = types are never > freed (we don't delete gdbarch objects), and even then they don't assume = that their > name has been dynamically allocated, they would not try to free it. Pushed with this change, thanks. Hannes