Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Cc: <palves@redhat.com>
Subject: [PATCH 1/3] Clean up server-kill.exp
Date: Wed, 08 Oct 2014 06:32:00 -0000	[thread overview]
Message-ID: <1412749679-27076-2-git-send-email-yao@codesourcery.com> (raw)
In-Reply-To: <1412749679-27076-1-git-send-email-yao@codesourcery.com>

This patch is to remove some lines which looks unnecessary.  These
lines were added when server-kill.exp was added.  In the version 1,
https://sourceware.org/ml/gdb-patches/2013-03/msg00691.html the test
calls runto_main and delete breakpoint on main,

+if ![runto_main] {
+    return -1
+}
+
+# Otherwise the breakpoint at 'main' would not cause insert breakpoints during
+# first step.
+delete_breakpoints

However, in the version 2
https://sourceware.org/ml/gdb-patches/2013-03/msg00854.html runto_main
is removed but delete_breakpoints is still there.  AFAICS, the line of
delete_breakpoints can be removed too.

gdb/testsuite:

2014-10-08  Yao Qi  <yao@codesourcery.com>

	* gdb.server/server-kill.exp: Remove "delete_breakpoints".
---
 gdb/testsuite/gdb.server/server-kill.exp | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/gdb/testsuite/gdb.server/server-kill.exp b/gdb/testsuite/gdb.server/server-kill.exp
index 5d31103..b23c2b5 100644
--- a/gdb/testsuite/gdb.server/server-kill.exp
+++ b/gdb/testsuite/gdb.server/server-kill.exp
@@ -33,10 +33,6 @@ gdb_test "disconnect" ".*"
 
 gdbserver_run ""
 
-# Otherwise the breakpoint at 'main' would not cause insert
-# breakpoints during first step.
-delete_breakpoints
-
 set server_pid [exp_pid -i [board_info target fileid]]
 remote_exec target "kill -9 $server_pid"
 
-- 
1.9.3


  parent reply	other threads:[~2014-10-08  6:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-30 13:15 [PATCH] Skip server-kill.exp on remote target Yao Qi
2014-10-07 13:55 ` Yao Qi
2014-10-07 15:21 ` Pedro Alves
2014-10-08  6:32   ` [PATCH 0/3] Tweak server-kill.exp for " Yao Qi
2014-10-08  6:32     ` [PATCH 2/3] Get GDBserver pid on " Yao Qi
2014-10-08 14:07       ` Pedro Alves
2014-10-08  6:32     ` [PATCH 3/3] Use command "monitor set debug 0" to check the connection Yao Qi
2014-10-08 14:19       ` Pedro Alves
2014-10-09  3:05         ` Yao Qi
2014-10-10  9:38           ` Pedro Alves
2014-10-10 13:52             ` Yao Qi
2014-10-10 13:57               ` Pedro Alves
2014-10-08  6:32     ` Yao Qi [this message]
2014-10-08 13:48       ` [PATCH 1/3] Clean up server-kill.exp Pedro Alves
2014-10-11  3:20     ` [PATCH 0/3] Tweak server-kill.exp for remote target Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1412749679-27076-2-git-send-email-yao@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox