Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: [PATCH] Skip server-kill.exp on remote target
Date: Tue, 30 Sep 2014 13:15:00 -0000	[thread overview]
Message-ID: <1412082645-30629-1-git-send-email-yao@codesourcery.com> (raw)

Hi,
We see the following fail in the real remote testing...

(gdb) Executing on target: kill -9 29808    (timeout = 300)
spawn [open ...]^M
sh: 1: kill: No such process

XYZ1ZYX
tstatus^M
Trace can not be run on this target.^M
(gdb) FAIL: gdb.server/server-kill.exp: tstatus

The test tries to kill gdbserver in this way:

set server_pid [exp_pid -i [board_info target fileid]]
remote_exec target "kill -9 $server_pid"

in native testing, we'll get the pid of spawned gdbserver, however, in
remote testing, we'll get the pid of ssh session, since we start
gdbserver on the remote target through ssh.  The pid on build doesn't
exist on target.

I thought about different ways to handle remote target, for example:

 - use command ps on remote target to gdbserver pid, but it doesn't work
   if we have multiple gdbserver instances during testing,
 - port number can be regarded as an id to differentiate different
   instances, but port number is unknown to each test case.  Likewise,
   we can't use 'pkill' due to the same reason.
 - close the gdbserver channel, but gdbserver doesn't exit on the target,

then, I have to skip this test for remote target.

gdb/testsuite:

2014-09-30  Yao Qi  <yao@codesourcery.com>

	* gdb.server/server-kill.exp: Skip it if the target is remote.
---
 gdb/testsuite/gdb.server/server-kill.exp | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/gdb/testsuite/gdb.server/server-kill.exp b/gdb/testsuite/gdb.server/server-kill.exp
index 5d31103..45af850 100644
--- a/gdb/testsuite/gdb.server/server-kill.exp
+++ b/gdb/testsuite/gdb.server/server-kill.exp
@@ -23,6 +23,11 @@ if {[skip_gdbserver_tests]} {
     return 0
 }
 
+# We can't get the pid of gdbserver on the remote target.
+if [is_remote target] then {
+    return 0
+}
+
 if { [prepare_for_testing ${testfile}.exp ${testfile}] } {
     return -1
 }
-- 
1.9.3


             reply	other threads:[~2014-09-30 13:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-30 13:15 Yao Qi [this message]
2014-10-07 13:55 ` Yao Qi
2014-10-07 15:21 ` Pedro Alves
2014-10-08  6:32   ` [PATCH 0/3] Tweak server-kill.exp for " Yao Qi
2014-10-08  6:32     ` [PATCH 1/3] Clean up server-kill.exp Yao Qi
2014-10-08 13:48       ` Pedro Alves
2014-10-08  6:32     ` [PATCH 2/3] Get GDBserver pid on remote target Yao Qi
2014-10-08 14:07       ` Pedro Alves
2014-10-08  6:32     ` [PATCH 3/3] Use command "monitor set debug 0" to check the connection Yao Qi
2014-10-08 14:19       ` Pedro Alves
2014-10-09  3:05         ` Yao Qi
2014-10-10  9:38           ` Pedro Alves
2014-10-10 13:52             ` Yao Qi
2014-10-10 13:57               ` Pedro Alves
2014-10-11  3:20     ` [PATCH 0/3] Tweak server-kill.exp for remote target Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1412082645-30629-1-git-send-email-yao@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox