From: Keven Boell <keven.boell@intel.com>
To: gdb-patches@sourceware.org
Cc: keven.boell@intel.com, sanimir.agovic@intel.com
Subject: [V2 08/23] vla: get dynamic array corner cases to work
Date: Fri, 11 Jul 2014 09:21:00 -0000 [thread overview]
Message-ID: <1405070495-6948-9-git-send-email-keven.boell@intel.com> (raw)
In-Reply-To: <1405070495-6948-1-git-send-email-keven.boell@intel.com>
This patch does not overwrite the value type in
case it is a dynamic type. For dynamic types GDB
resolved its dynamic values in a copy of the type.
The call to deprecated_set_value_type overwrites the
resolved type with the original type, which breaks
e.g. pointer to a Fortran type, which contains a dynamic
array.
Old:
(gdb) print &vla1
(PTR TO -> ( real(kind=4) (23959136:23959184))) 0x7fffffffd490
New:
(gdb) print &vla1
(PTR TO -> ( real(kind=4) (5))) 0x7fffffffd490
2014-05-28 Keven Boell <keven.boell@intel.com>
Sanimir Agovic <sanimir.agovic@intel.com>
* value.c (readjust_indirect_value_type): Add
check for dynamic types.
Change-Id: If1c6fb0bd3c1d04619e89a1b58850edb69bbfde0
Signed-off-by: Keven Boell <keven.boell@intel.com>
---
gdb/value.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gdb/value.c b/gdb/value.c
index ff5df8d..0d53d12 100644
--- a/gdb/value.c
+++ b/gdb/value.c
@@ -3568,7 +3568,8 @@ readjust_indirect_value_type (struct value *value, struct type *enc_type,
struct value *original_value)
{
/* Re-adjust type. */
- deprecated_set_value_type (value, TYPE_TARGET_TYPE (original_type));
+ if (!is_dynamic_type (TYPE_TARGET_TYPE (original_type)))
+ deprecated_set_value_type (value, TYPE_TARGET_TYPE (original_type));
/* Add embedding info. */
set_value_enclosing_type (value, enc_type);
--
1.7.9.5
next prev parent reply other threads:[~2014-07-11 9:21 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 9:21 [V2 00/23] Fortran dynamic array support Keven Boell
2014-07-11 9:21 ` [V2 19/23] test: accessing dynamic array history values Keven Boell
2014-07-11 9:21 ` [V2 12/23] vla: add NEWS entry for dynamic array support Keven Boell
2014-07-11 9:58 ` Eli Zaretskii
2014-07-11 9:21 ` [V2 09/23] vla: changed string length semantic Keven Boell
2014-07-18 15:38 ` Jan Kratochvil
2014-07-21 13:23 ` Keven Boell
2014-07-21 19:54 ` Jan Kratochvil
2014-07-22 15:27 ` Keven Boell
2014-07-11 9:21 ` Keven Boell [this message]
2014-07-11 9:21 ` [V2 21/23] test: basic MI test for the dynamic array support Keven Boell
2014-07-11 9:21 ` [V2 01/23] dwarf: add dwarf3 DW_OP_push_object_address opcode Keven Boell
2014-07-11 9:21 ` [V2 16/23] test: correct ptype of dynamic arrays in Fortran Keven Boell
2014-07-11 9:21 ` [V2 05/23] vla: make field selection work with vla Keven Boell
2014-07-11 9:22 ` [V2 04/23] vla: make dynamic fortran arrays functional Keven Boell
2014-07-11 9:22 ` [V2 06/23] vla: reconstruct value to compute bounds of target type Keven Boell
2014-07-11 9:22 ` [V2 02/23] dwarf: add DW_AT_data_location support Keven Boell
2014-07-11 9:22 ` [V2 14/23] test: evaluate dynamic arrays using Fortran primitives Keven Boell
2014-07-11 9:22 ` [V2 03/23] vla: introduce allocated/associated flags Keven Boell
2014-07-11 9:22 ` [V2 23/23] test: stride support for dynamic arrays Keven Boell
2014-07-11 9:22 ` [V2 17/23] test: evaluating allocation/association status Keven Boell
2014-07-11 9:22 ` [V2 20/23] test: dynamic string evaluations Keven Boell
2014-07-11 9:22 ` [V2 07/23] vla: use value constructor instead of raw-buffer manipulation Keven Boell
2014-07-11 9:22 ` [V2 18/23] test: dynamic arrays passed to functions Keven Boell
2014-07-11 9:22 ` [V2 13/23] test: basic tests for dynamic array evaluations in Fortran Keven Boell
2014-07-11 9:22 ` [V2 15/23] test: dynamic arrays passed to subroutines Keven Boell
2014-08-01 20:11 ` Jan Kratochvil
2014-08-07 6:58 ` Keven Boell
2014-08-12 6:56 ` Keven Boell
2014-07-11 9:22 ` [V2 22/23] test: test sizeof for dynamic fortran arrays Keven Boell
2014-07-11 9:22 ` [V2 11/23] vla: add stride support to " Keven Boell
2014-07-11 9:28 ` [V2 10/23] vla: get Fortran dynamic strings working Keven Boell
2014-07-11 16:23 ` [V2 00/23] Fortran dynamic array support Jan Kratochvil
2014-07-16 16:19 ` Keven Boell
2014-07-16 16:33 ` Jan Kratochvil
2014-07-18 12:33 ` Keven Boell
2014-07-18 15:19 ` Jan Kratochvil
2014-07-29 19:35 ` Crash regression(?) printing Fortran strings in bt [Re: [V2 00/23] Fortran dynamic array support] Jan Kratochvil
2014-07-29 20:51 ` Jan Kratochvil
2014-08-01 7:20 ` Keven Boell
2014-08-01 7:22 ` Jan Kratochvil
2014-08-01 21:02 ` [patch 1/2] " Jan Kratochvil
2014-08-12 6:56 ` Keven Boell
2014-08-12 21:55 ` Jan Kratochvil
2014-08-14 20:03 ` Jan Kratochvil
2014-08-20 14:09 ` Keven Boell
2014-08-20 18:24 ` Jan Kratochvil
2014-08-21 7:27 ` Keven Boell
2014-08-21 14:29 ` Jan Kratochvil
2014-08-22 7:20 ` Jan Kratochvil
2014-08-01 21:05 ` [patch 2/2] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405070495-6948-9-git-send-email-keven.boell@intel.com \
--to=keven.boell@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=sanimir.agovic@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox