Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Keven Boell <keven.boell@intel.com>
To: gdb-patches@sourceware.org
Cc: keven.boell@intel.com, sanimir.agovic@intel.com
Subject: [V2 10/23] vla: get Fortran dynamic strings working.
Date: Fri, 11 Jul 2014 09:28:00 -0000	[thread overview]
Message-ID: <1405070495-6948-11-git-send-email-keven.boell@intel.com> (raw)
In-Reply-To: <1405070495-6948-1-git-send-email-keven.boell@intel.com>

This patch enables the correct calculation of dynamic
string length.

Old:
(gdb) p my_dyn_string
$1 = (PTR TO -> ( character*23959136 )) 0x605fc0

(gdb) p *my_dyn_string
Cannot access memory at address 0x605fc0

New:
(gdb) p my_dyn_string
$1 = (PTR TO -> ( character*10 )) 0x605fc0

(gdb) p *my_dyn_string
$2 = 'foo'

2014-05-28  Keven Boell  <keven.boell@intel.com>
            Sanimir Agovic  <sanimir.agovic@intel.com>

	* gdbtypes.c (resolve_dynamic_type): Add
	conditions to support string types.
	(resolve_dynamic_array): Add conditions for dynamic
	strings and create a new string type.
	(is_dynamic_type): Follow pointer if a string type
	was detected, as Fortran strings are represented
	as pointers to strings internally.

Change-Id: I7d54d762a081ce034be37ac3e368bac8111dc4e6

Signed-off-by: Keven Boell <keven.boell@intel.com>
---
 gdb/gdbtypes.c |   29 ++++++++++++++++++++++++-----
 1 file changed, 24 insertions(+), 5 deletions(-)

diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c
index c7c5c3b..da773f6 100644
--- a/gdb/gdbtypes.c
+++ b/gdb/gdbtypes.c
@@ -1675,6 +1675,17 @@ is_dynamic_type (struct type *type)
 	      && is_dynamic_type (TYPE_FIELD_TYPE (type, i)))
 	    return 1;
       }
+    case TYPE_CODE_PTR:
+      {
+        if (TYPE_TARGET_TYPE (type)
+            && TYPE_CODE (TYPE_TARGET_TYPE (type)) == TYPE_CODE_STRING)
+          return is_dynamic_type (check_typedef (TYPE_TARGET_TYPE (type)));
+
+        return 0;
+        break;
+      }
+    default:
+      return 0;
       break;
     }
 
@@ -1745,7 +1756,8 @@ resolve_dynamic_array (struct type *type, CORE_ADDR addr)
   struct dynamic_prop *prop;
   struct type *copy = copy_type (type);
 
-  gdb_assert (TYPE_CODE (type) == TYPE_CODE_ARRAY);
+  gdb_assert (TYPE_CODE (type) == TYPE_CODE_ARRAY
+              || TYPE_CODE (type) == TYPE_CODE_STRING);
 
   elt_type = type;
   range_type = check_typedef (TYPE_INDEX_TYPE (elt_type));
@@ -1767,14 +1779,20 @@ resolve_dynamic_array (struct type *type, CORE_ADDR addr)
 
   ary_dim = check_typedef (TYPE_TARGET_TYPE (elt_type));
 
-  if (ary_dim != NULL && TYPE_CODE (ary_dim) == TYPE_CODE_ARRAY)
+  if (ary_dim != NULL && (TYPE_CODE (ary_dim) == TYPE_CODE_ARRAY
+          || TYPE_CODE (ary_dim) == TYPE_CODE_STRING))
     elt_type = resolve_dynamic_array (TYPE_TARGET_TYPE (copy), addr);
   else
     elt_type = TYPE_TARGET_TYPE (type);
 
-  return create_array_type (copy,
-			    elt_type,
-			    range_type);
+  if (TYPE_CODE (type) == TYPE_CODE_STRING)
+    return create_string_type (copy,
+            elt_type,
+            range_type);
+  else
+    return create_array_type (copy,
+            elt_type,
+            range_type);
 }
 
 /* Resolve dynamic bounds of members of the union TYPE to static
@@ -1901,6 +1919,7 @@ resolve_dynamic_type (struct type *type, CORE_ADDR addr)
 	}
 
       case TYPE_CODE_ARRAY:
+      case TYPE_CODE_STRING:
 	resolved_type = resolve_dynamic_array (type, addr);
 	break;
 
-- 
1.7.9.5


  parent reply	other threads:[~2014-07-11  9:21 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-11  9:21 [V2 00/23] Fortran dynamic array support Keven Boell
2014-07-11  9:21 ` [V2 12/23] vla: add NEWS entry for " Keven Boell
2014-07-11  9:58   ` Eli Zaretskii
2014-07-11  9:21 ` [V2 19/23] test: accessing dynamic array history values Keven Boell
2014-07-11  9:21 ` [V2 09/23] vla: changed string length semantic Keven Boell
2014-07-18 15:38   ` Jan Kratochvil
2014-07-21 13:23     ` Keven Boell
2014-07-21 19:54       ` Jan Kratochvil
2014-07-22 15:27         ` Keven Boell
2014-07-11  9:21 ` [V2 21/23] test: basic MI test for the dynamic array support Keven Boell
2014-07-11  9:21 ` [V2 08/23] vla: get dynamic array corner cases to work Keven Boell
2014-07-11  9:21 ` [V2 01/23] dwarf: add dwarf3 DW_OP_push_object_address opcode Keven Boell
2014-07-11  9:21 ` [V2 16/23] test: correct ptype of dynamic arrays in Fortran Keven Boell
2014-07-11  9:21 ` [V2 05/23] vla: make field selection work with vla Keven Boell
2014-07-11  9:22 ` [V2 06/23] vla: reconstruct value to compute bounds of target type Keven Boell
2014-07-11  9:22 ` [V2 04/23] vla: make dynamic fortran arrays functional Keven Boell
2014-07-11  9:22 ` [V2 02/23] dwarf: add DW_AT_data_location support Keven Boell
2014-07-11  9:22 ` [V2 14/23] test: evaluate dynamic arrays using Fortran primitives Keven Boell
2014-07-11  9:22 ` [V2 03/23] vla: introduce allocated/associated flags Keven Boell
2014-07-11  9:22 ` [V2 23/23] test: stride support for dynamic arrays Keven Boell
2014-07-11  9:22 ` [V2 15/23] test: dynamic arrays passed to subroutines Keven Boell
2014-08-01 20:11   ` Jan Kratochvil
2014-08-07  6:58     ` Keven Boell
2014-08-12  6:56       ` Keven Boell
2014-07-11  9:22 ` [V2 22/23] test: test sizeof for dynamic fortran arrays Keven Boell
2014-07-11  9:22 ` [V2 11/23] vla: add stride support to " Keven Boell
2014-07-11  9:22 ` [V2 17/23] test: evaluating allocation/association status Keven Boell
2014-07-11  9:22 ` [V2 20/23] test: dynamic string evaluations Keven Boell
2014-07-11  9:22 ` [V2 07/23] vla: use value constructor instead of raw-buffer manipulation Keven Boell
2014-07-11  9:22 ` [V2 13/23] test: basic tests for dynamic array evaluations in Fortran Keven Boell
2014-07-11  9:22 ` [V2 18/23] test: dynamic arrays passed to functions Keven Boell
2014-07-11  9:28 ` Keven Boell [this message]
2014-07-11 16:23 ` [V2 00/23] Fortran dynamic array support Jan Kratochvil
2014-07-16 16:19   ` Keven Boell
2014-07-16 16:33     ` Jan Kratochvil
2014-07-18 12:33       ` Keven Boell
2014-07-18 15:19         ` Jan Kratochvil
2014-07-29 19:35 ` Crash regression(?) printing Fortran strings in bt [Re: [V2 00/23] Fortran dynamic array support] Jan Kratochvil
2014-07-29 20:51   ` Jan Kratochvil
2014-08-01  7:20     ` Keven Boell
2014-08-01  7:22       ` Jan Kratochvil
2014-08-01 21:02       ` [patch 1/2] " Jan Kratochvil
2014-08-12  6:56         ` Keven Boell
2014-08-12 21:55           ` Jan Kratochvil
2014-08-14 20:03             ` Jan Kratochvil
2014-08-20 14:09               ` Keven Boell
2014-08-20 18:24                 ` Jan Kratochvil
2014-08-21  7:27                   ` Keven Boell
2014-08-21 14:29                     ` Jan Kratochvil
2014-08-22  7:20                     ` Jan Kratochvil
2014-08-01 21:05   ` [patch 2/2] " Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1405070495-6948-11-git-send-email-keven.boell@intel.com \
    --to=keven.boell@intel.com \
    --cc=gdb-patches@sourceware.org \
    --cc=sanimir.agovic@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox