From: Pedro Alves <palves@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 7/7] bsd-uthread.c: Don't install a to_xfer_partial method
Date: Wed, 19 Feb 2014 20:29:00 -0000 [thread overview]
Message-ID: <1392841775-19126-8-git-send-email-palves@redhat.com> (raw)
In-Reply-To: <1392841775-19126-1-git-send-email-palves@redhat.com>
Whatever the comment about deprecated_xfer_memory referred to,
deprecated_xfer_memory is gone now. There's no need to install a
target method that just delegates, as that's what the default
delegator does already.
Tested by building an --enable-targets=all gdb on x86_64 Fedora 17.
gdb/
2014-02-19 Pedro Alves <palves@redhat.com>
* bsd-uthread.c (bsd_uthread_xfer_partial): Delete function.
(bsd_uthread_target): Don't install bsd_uthread_xfer_partial as
to_xfer_partial method.
---
gdb/bsd-uthread.c | 16 ----------------
1 file changed, 16 deletions(-)
diff --git a/gdb/bsd-uthread.c b/gdb/bsd-uthread.c
index 39bc05a..5f55763 100644
--- a/gdb/bsd-uthread.c
+++ b/gdb/bsd-uthread.c
@@ -331,21 +331,6 @@ bsd_uthread_store_registers (struct target_ops *ops,
}
}
-/* Implement the to_xfer_partial target_ops method. FIXME: This
- function is only there because otherwise GDB tries to invoke
- deprecate_xfer_memory. */
-
-static enum target_xfer_status
-bsd_uthread_xfer_partial (struct target_ops *ops, enum target_object object,
- const char *annex, gdb_byte *readbuf,
- const gdb_byte *writebuf,
- ULONGEST offset, ULONGEST len, ULONGEST *xfered_len)
-{
- gdb_assert (ops->beneath->to_xfer_partial);
- return ops->beneath->to_xfer_partial (ops->beneath, object, annex, readbuf,
- writebuf, offset, len, xfered_len);
-}
-
static ptid_t
bsd_uthread_wait (struct target_ops *ops,
ptid_t ptid, struct target_waitstatus *status, int options)
@@ -529,7 +514,6 @@ bsd_uthread_target (void)
t->to_mourn_inferior = bsd_uthread_mourn_inferior;
t->to_fetch_registers = bsd_uthread_fetch_registers;
t->to_store_registers = bsd_uthread_store_registers;
- t->to_xfer_partial = bsd_uthread_xfer_partial;
t->to_wait = bsd_uthread_wait;
t->to_resume = bsd_uthread_resume;
t->to_thread_alive = bsd_uthread_thread_alive;
--
1.7.11.7
next prev parent reply other threads:[~2014-02-19 20:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 20:29 [PATCH 0/7] eliminate deprecated_xfer_memory Pedro Alves
2014-02-19 20:29 ` [PATCH 5/7] go32-nat.c: Don't install a deprecated_xfer_memory method Pedro Alves
[not found] ` <00c801cf2e59$acae60f0$060b22d0$@muller@ics-cnrs.unistra.fr>
2014-02-20 16:37 ` Pedro Alves
2014-02-19 20:29 ` [PATCH 2/7] remote-m32r-sdi.c: " Pedro Alves
2014-02-19 20:29 ` [PATCH 4/7] nto-procfs.c: " Pedro Alves
2014-02-19 20:29 ` [PATCH 3/7] procfs.c: " Pedro Alves
2014-02-20 15:48 ` Joel Brobecker
2014-02-20 15:56 ` Joel Brobecker
2014-02-20 16:38 ` Pedro Alves
2014-02-24 17:53 ` Joel Brobecker
2014-02-24 18:21 ` Pedro Alves
2014-02-24 18:37 ` Joel Brobecker
2014-02-19 20:29 ` [PATCH 1/7] remote-mips.c: " Pedro Alves
2014-02-19 20:29 ` [PATCH 6/7] eliminate target_ops->deprecated_xfer_memory Pedro Alves
2014-02-19 20:29 ` Pedro Alves [this message]
2014-02-20 13:26 ` [PATCH 7/7] bsd-uthread.c: Don't install a to_xfer_partial method Mark Kettenis
2014-02-20 16:42 ` Pedro Alves
2014-02-20 18:27 ` [PATCH 0/7] eliminate deprecated_xfer_memory Tom Tromey
2014-02-26 14:50 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392841775-19126-8-git-send-email-palves@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox