From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21268 invoked by alias); 19 Feb 2014 20:29:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21172 invoked by uid 89); 19 Feb 2014 20:29:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Feb 2014 20:29:45 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1JKTiqa016346 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 19 Feb 2014 15:29:44 -0500 Received: from brno.lan (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s1JKTamt025004 for ; Wed, 19 Feb 2014 15:29:43 -0500 From: Pedro Alves To: gdb-patches@sourceware.org Subject: [PATCH 7/7] bsd-uthread.c: Don't install a to_xfer_partial method Date: Wed, 19 Feb 2014 20:29:00 -0000 Message-Id: <1392841775-19126-8-git-send-email-palves@redhat.com> In-Reply-To: <1392841775-19126-1-git-send-email-palves@redhat.com> References: <1392841775-19126-1-git-send-email-palves@redhat.com> X-SW-Source: 2014-02/txt/msg00612.txt.bz2 Whatever the comment about deprecated_xfer_memory referred to, deprecated_xfer_memory is gone now. There's no need to install a target method that just delegates, as that's what the default delegator does already. Tested by building an --enable-targets=all gdb on x86_64 Fedora 17. gdb/ 2014-02-19 Pedro Alves * bsd-uthread.c (bsd_uthread_xfer_partial): Delete function. (bsd_uthread_target): Don't install bsd_uthread_xfer_partial as to_xfer_partial method. --- gdb/bsd-uthread.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/gdb/bsd-uthread.c b/gdb/bsd-uthread.c index 39bc05a..5f55763 100644 --- a/gdb/bsd-uthread.c +++ b/gdb/bsd-uthread.c @@ -331,21 +331,6 @@ bsd_uthread_store_registers (struct target_ops *ops, } } -/* Implement the to_xfer_partial target_ops method. FIXME: This - function is only there because otherwise GDB tries to invoke - deprecate_xfer_memory. */ - -static enum target_xfer_status -bsd_uthread_xfer_partial (struct target_ops *ops, enum target_object object, - const char *annex, gdb_byte *readbuf, - const gdb_byte *writebuf, - ULONGEST offset, ULONGEST len, ULONGEST *xfered_len) -{ - gdb_assert (ops->beneath->to_xfer_partial); - return ops->beneath->to_xfer_partial (ops->beneath, object, annex, readbuf, - writebuf, offset, len, xfered_len); -} - static ptid_t bsd_uthread_wait (struct target_ops *ops, ptid_t ptid, struct target_waitstatus *status, int options) @@ -529,7 +514,6 @@ bsd_uthread_target (void) t->to_mourn_inferior = bsd_uthread_mourn_inferior; t->to_fetch_registers = bsd_uthread_fetch_registers; t->to_store_registers = bsd_uthread_store_registers; - t->to_xfer_partial = bsd_uthread_xfer_partial; t->to_wait = bsd_uthread_wait; t->to_resume = bsd_uthread_resume; t->to_thread_alive = bsd_uthread_thread_alive; -- 1.7.11.7