From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@redhat.com>
Subject: [PATCH v3 02/17] fix some simple thinkos in the test suite
Date: Fri, 25 Oct 2013 20:21:00 -0000 [thread overview]
Message-ID: <1382732464-28121-3-git-send-email-tromey@redhat.com> (raw)
In-Reply-To: <1382732464-28121-1-git-send-email-tromey@redhat.com>
This fixes some parallelization thinkos from a while ago. I'm not
sure how the problems ever slipped through. In addition to a thinko
fix in twice.exp, this also finishes fixing it up for parallelization.
~ChangeLog~
2013-10-24 Tom Tromey <tromey@redhat.com>
* gdb.base/gcore-buffer-overflow.exp: Use
standard_output_file, not standard_testfile.
* gdb.base/twice.exp: Use standard_testfile, not
standard_output_file. Use gdb_remote_download.
---
gdb/testsuite/ChangeLog | 7 +++++++
gdb/testsuite/gdb.base/gcore-buffer-overflow.exp | 3 ++-
gdb/testsuite/gdb.base/twice.exp | 4 ++--
3 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/gdb/testsuite/gdb.base/gcore-buffer-overflow.exp b/gdb/testsuite/gdb.base/gcore-buffer-overflow.exp
index 8d0867e..47dccf9 100644
--- a/gdb/testsuite/gdb.base/gcore-buffer-overflow.exp
+++ b/gdb/testsuite/gdb.base/gcore-buffer-overflow.exp
@@ -51,4 +51,5 @@ if { ! [ runto_main ] } then {
return -1
}
-gdb_gcore_cmd [standard_testfile gcore-buffer-overflow.test] "save a corefile"
+gdb_gcore_cmd [standard_output_file gcore-buffer-overflow.test] \
+ "save a corefile"
diff --git a/gdb/testsuite/gdb.base/twice.exp b/gdb/testsuite/gdb.base/twice.exp
index 936ddcb..9e7e334 100644
--- a/gdb/testsuite/gdb.base/twice.exp
+++ b/gdb/testsuite/gdb.base/twice.exp
@@ -14,7 +14,7 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>.
-standard_output_file twice.c
+standard_testfile twice.c
set options debug
lappend options "additional_flags=-I."
@@ -23,7 +23,7 @@ set fileid [open $local_srcfile w]
puts $fileid "#include \"twice.c\""
close $fileid
-remote_download host ${srcdir}/${subdir}/twice.c twice.c
+gdb_remote_download host ${srcdir}/${subdir}/twice.c
if { [gdb_compile $local_srcfile "${binfile}" executable $options] != "" } {
untested twice.exp
--
1.8.1.4
next prev parent reply other threads:[~2013-10-25 20:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-25 20:21 [PATCH v3 00/17] test suite parallel safety Tom Tromey
2013-10-25 20:21 ` [PATCH v3 13/17] make gdb.asm parallel-safe Tom Tromey
2013-10-25 20:21 ` [PATCH v3 12/17] fix up gdb.server Tom Tromey
2013-10-25 20:21 ` Tom Tromey [this message]
2013-10-25 20:21 ` [PATCH v3 14/17] fix argv0-symlink.exp for parallel mode Tom Tromey
2013-10-25 20:21 ` [PATCH v3 03/17] fix weird.exp for parallel testing Tom Tromey
2013-10-25 20:21 ` [PATCH v3 08/17] simple changes in gdb.base Tom Tromey
2013-10-25 20:21 ` [PATCH v3 17/17] switch to fully parallel mode Tom Tromey
2013-10-25 20:21 ` [PATCH v3 05/17] fix up gdb.xml Tom Tromey
2013-10-28 11:23 ` Pedro Alves
2013-10-28 14:30 ` Tom Tromey
2013-10-25 20:21 ` [PATCH v3 04/17] fix up gdb.gdb Tom Tromey
2013-10-25 20:21 ` [PATCH v3 01/17] fix up log-file toggling Tom Tromey
2013-10-25 20:21 ` [PATCH v3 07/17] fix up gdb.trace Tom Tromey
2013-10-25 20:24 ` [PATCH v3 09/17] update checkpoint test Tom Tromey
2013-10-25 20:36 ` [PATCH v3 11/17] introduce relative_filename and use it Tom Tromey
2013-10-25 20:36 ` [PATCH v3 06/17] fix up gdb.mi Tom Tromey
2013-10-25 20:44 ` [PATCH v3 15/17] fix some "exec" tests Tom Tromey
2013-10-25 21:11 ` [PATCH v3 10/17] update fileio test Tom Tromey
2013-10-25 21:11 ` [PATCH v3 16/17] fix some fission tests Tom Tromey
2013-11-04 18:54 ` [PATCH v3 00/17] test suite parallel safety Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382732464-28121-3-git-send-email-tromey@redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox