From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@redhat.com>
Subject: [PATCH v3 12/17] fix up gdb.server
Date: Fri, 25 Oct 2013 20:21:00 -0000 [thread overview]
Message-ID: <1382732464-28121-13-git-send-email-tromey@redhat.com> (raw)
In-Reply-To: <1382732464-28121-1-git-send-email-tromey@redhat.com>
This fixes gdb.server to be parallel-safe.
~ChangeLog~
2013-10-24 Tom Tromey <tromey@redhat.com>
* gdb.server/file-transfer.exp: Use standard_output_file.
---
gdb/testsuite/ChangeLog | 4 ++++
gdb/testsuite/gdb.server/file-transfer.exp | 21 ++++++++++++++-------
2 files changed, 18 insertions(+), 7 deletions(-)
diff --git a/gdb/testsuite/gdb.server/file-transfer.exp b/gdb/testsuite/gdb.server/file-transfer.exp
index aa56380..841d757 100644
--- a/gdb/testsuite/gdb.server/file-transfer.exp
+++ b/gdb/testsuite/gdb.server/file-transfer.exp
@@ -35,15 +35,22 @@ gdb_test "disconnect" ".*"
gdbserver_run ""
proc test_file_transfer { filename description } {
- gdb_test "remote put \"$filename\" down-server" \
+ set up_server up-server
+ set down_server down-server
+ if {![is_remote host] && ![is_remote target]} {
+ set up_server [standard_output_file $up_server]
+ set down_server [standard_output_file $down_server]
+ }
+
+ gdb_test "remote put \"$filename\" $down_server" \
"Successfully sent .*" "put $description"
- gdb_test "remote get down-server up-server" \
+ gdb_test "remote get $down_server $up_server" \
"Successfully fetched .*" "get $description"
if { ![is_remote target] } {
# If we can check the target copy of the file, do that too.
# This should catch symmetric errors in upload and download.
- set result [remote_exec host "cmp -s $filename down-server"]
+ set result [remote_exec host "cmp -s $filename $down_server"]
if { [lindex $result 0] == 0 } {
pass "compare intermediate $description"
} else {
@@ -51,25 +58,25 @@ proc test_file_transfer { filename description } {
}
}
- set result [remote_exec host "cmp -s $filename up-server"]
+ set result [remote_exec host "cmp -s $filename $up_server"]
if { [lindex $result 0] == 0 } {
pass "compare $description"
} else {
fail "compare $description"
}
- gdb_test "remote delete down-server" \
+ gdb_test "remote delete $down_server" \
"Successfully deleted .*" "deleted $description"
if { ![is_remote target] } {
- if { ! [remote_file target exists down-server] } {
+ if { ! [remote_file target exists $down_server] } {
pass "verified deleted $description"
} else {
fail "verified deleted $description"
}
}
- catch { file delete up-server }
+ catch { file delete $up_server }
}
test_file_transfer "$binfile" "binary file"
--
1.8.1.4
next prev parent reply other threads:[~2013-10-25 20:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-25 20:21 [PATCH v3 00/17] test suite parallel safety Tom Tromey
2013-10-25 20:21 ` Tom Tromey [this message]
2013-10-25 20:21 ` [PATCH v3 13/17] make gdb.asm parallel-safe Tom Tromey
2013-10-25 20:21 ` [PATCH v3 03/17] fix weird.exp for parallel testing Tom Tromey
2013-10-25 20:21 ` [PATCH v3 14/17] fix argv0-symlink.exp for parallel mode Tom Tromey
2013-10-25 20:21 ` [PATCH v3 02/17] fix some simple thinkos in the test suite Tom Tromey
2013-10-25 20:21 ` [PATCH v3 17/17] switch to fully parallel mode Tom Tromey
2013-10-25 20:21 ` [PATCH v3 08/17] simple changes in gdb.base Tom Tromey
2013-10-25 20:21 ` [PATCH v3 05/17] fix up gdb.xml Tom Tromey
2013-10-28 11:23 ` Pedro Alves
2013-10-28 14:30 ` Tom Tromey
2013-10-25 20:21 ` [PATCH v3 04/17] fix up gdb.gdb Tom Tromey
2013-10-25 20:21 ` [PATCH v3 01/17] fix up log-file toggling Tom Tromey
2013-10-25 20:21 ` [PATCH v3 07/17] fix up gdb.trace Tom Tromey
2013-10-25 20:24 ` [PATCH v3 09/17] update checkpoint test Tom Tromey
2013-10-25 20:36 ` [PATCH v3 06/17] fix up gdb.mi Tom Tromey
2013-10-25 20:36 ` [PATCH v3 11/17] introduce relative_filename and use it Tom Tromey
2013-10-25 20:44 ` [PATCH v3 15/17] fix some "exec" tests Tom Tromey
2013-10-25 21:11 ` [PATCH v3 10/17] update fileio test Tom Tromey
2013-10-25 21:11 ` [PATCH v3 16/17] fix some fission tests Tom Tromey
2013-11-04 18:54 ` [PATCH v3 00/17] test suite parallel safety Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382732464-28121-13-git-send-email-tromey@redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox